third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_h.template - Issue 2004313003: DevTools: migrate from OwnPtr to std::unique_ptr for inspector protocol classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_h.template

Issue 2004313003: DevTools: migrate from OwnPtr to std::unique_ptr for inspector protocol classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaselined Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_cpp.template ('k') | third_party/WebKit/Source/platform/inspector_protocol/Frontend_cpp.template » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_h.template

diff --git a/third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_h.template b/third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_h.template

index cda88f7a0dbfa068e81ed9b923f3590ba0da2c30..28c642581e28aa18d787ec5af69eb0bd2f76420d 100644

--- a/third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_h.template

+++ b/third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_h.template

@@ -18,21 +18,21 @@ class DispatcherImplWeakPtr;

class PLATFORM_EXPORT Dispatcher {

public:

- static PassOwnPtr<Dispatcher> create(FrontendChannel* frontendChannel);

+ static std::unique_ptr<Dispatcher> create(FrontendChannel* frontendChannel);

virtual ~Dispatcher() { }

class PLATFORM_EXPORT CallbackBase {

public:

- CallbackBase(PassOwnPtr<DispatcherImplWeakPtr> backendImpl, int callId);

+ CallbackBase(std::unique_ptr<DispatcherImplWeakPtr> backendImpl, int callId);

virtual ~CallbackBase();

void sendFailure(const ErrorString&);

void dispose();

protected:

- void sendIfActive(PassOwnPtr<protocol::DictionaryValue> partialMessage, const ErrorString& invocationError);

+ void sendIfActive(std::unique_ptr<protocol::DictionaryValue> partialMessage, const ErrorString& invocationError);

private:

- OwnPtr<DispatcherImplWeakPtr> m_backendImpl;

+ std::unique_ptr<DispatcherImplWeakPtr> m_backendImpl;

int m_callId;

};