Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptCallStack.cpp

Issue 2004313003: DevTools: migrate from OwnPtr to std::unique_ptr for inspector protocol classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebaselined Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptCallStack.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptCallStack.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptCallStack.cpp
index e00c482e488e53cd39da2feccdad6b0eaa8d6d9c..6b954e3af0b1995f7b56c99f86c9998953cd36e6 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptCallStack.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptCallStack.cpp
@@ -45,7 +45,7 @@ PassRefPtr<ScriptCallStack> ScriptCallStack::create(v8::Isolate* isolate, v8::Lo
V8PerIsolateData* data = V8PerIsolateData::from(isolate);
if (!data->threadDebugger())
return nullptr;
- OwnPtr<V8StackTrace> stack = data->threadDebugger()->debugger()->createStackTrace(stackTrace, maxStackSize);
+ std::unique_ptr<V8StackTrace> stack = data->threadDebugger()->debugger()->createStackTrace(stackTrace, maxStackSize);
return stack ? adoptRef(new ScriptCallStack(std::move(stack))) : nullptr;
}
@@ -58,7 +58,7 @@ PassRefPtr<ScriptCallStack> ScriptCallStack::capture(size_t maxStackSize)
if (!data->threadDebugger())
return nullptr;
ScriptForbiddenScope::AllowUserAgentScript allowScripting;
- OwnPtr<V8StackTrace> stack = data->threadDebugger()->debugger()->captureStackTrace(maxStackSize);
+ std::unique_ptr<V8StackTrace> stack = data->threadDebugger()->debugger()->captureStackTrace(maxStackSize);
return stack ? adoptRef(new ScriptCallStack(std::move(stack))) : nullptr;
}
@@ -75,7 +75,7 @@ PassRefPtr<ScriptCallStack> ScriptCallStack::captureForConsole()
return ScriptCallStack::capture(stackSize);
}
-ScriptCallStack::ScriptCallStack(PassOwnPtr<V8StackTrace> stackTrace)
+ScriptCallStack::ScriptCallStack(std::unique_ptr<V8StackTrace> stackTrace)
: m_stackTrace(std::move(stackTrace))
{
}
@@ -104,7 +104,7 @@ unsigned ScriptCallStack::topColumnNumber() const
return m_stackTrace->topColumnNumber();
}
-PassOwnPtr<protocol::Runtime::StackTrace> ScriptCallStack::buildInspectorObject() const
+std::unique_ptr<protocol::Runtime::StackTrace> ScriptCallStack::buildInspectorObject() const
{
return m_stackTrace->buildInspectorObject();
}
@@ -129,10 +129,9 @@ String ScriptCallStack::toString() const
return m_stackTrace->toString();
}
-PassOwnPtr<V8StackTrace> ScriptCallStack::copyStackTrace() const
+std::unique_ptr<V8StackTrace> ScriptCallStack::copyStackTrace() const
{
return m_stackTrace ? m_stackTrace->clone() : nullptr;
}
-
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698