third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.h - Issue 2004313003: DevTools: migrate from OwnPtr to std::unique_ptr for inspector protocol classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.h

Issue 2004313003: DevTools: migrate from OwnPtr to std::unique_ptr for inspector protocol classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaselined Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp ('k') | third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.h

diff --git a/third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.h b/third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.h

index 6381c9eded7734e8063169cb3f532ed5c1ceb040..e25d352c5d4f1a9b88502265c0559e0d23a33f85 100644

--- a/third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.h

+++ b/third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.h

@@ -68,12 +68,12 @@ private:

// protocol::Dispatcher::DOMStorageCommandHandler overrides.

void enable(ErrorString*) override;

void disable(ErrorString*) override;

- void getDOMStorageItems(ErrorString*, PassOwnPtr<protocol::DOMStorage::StorageId> in_storageId, OwnPtr<protocol::Array<protocol::Array<String>>>* out_entries) override;

- void setDOMStorageItem(ErrorString*, PassOwnPtr<protocol::DOMStorage::StorageId> in_storageId, const String& in_key, const String& in_value) override;

- void removeDOMStorageItem(ErrorString*, PassOwnPtr<protocol::DOMStorage::StorageId> in_storageId, const String& in_key) override;

+ void getDOMStorageItems(ErrorString*, std::unique_ptr<protocol::DOMStorage::StorageId> in_storageId, std::unique_ptr<protocol::Array<protocol::Array<String>>>* out_entries) override;

+ void setDOMStorageItem(ErrorString*, std::unique_ptr<protocol::DOMStorage::StorageId> in_storageId, const String& in_key, const String& in_value) override;

+ void removeDOMStorageItem(ErrorString*, std::unique_ptr<protocol::DOMStorage::StorageId> in_storageId, const String& in_key) override;

- StorageArea* findStorageArea(ErrorString*, PassOwnPtr<protocol::DOMStorage::StorageId>, LocalFrame*&);

- PassOwnPtr<protocol::DOMStorage::StorageId> storageId(SecurityOrigin*, bool isLocalStorage);

+ StorageArea* findStorageArea(ErrorString*, std::unique_ptr<protocol::DOMStorage::StorageId>, LocalFrame*&);

+ std::unique_ptr<protocol::DOMStorage::StorageId> storageId(SecurityOrigin*, bool isLocalStorage);

Member<Page> m_page;

bool m_isEnabled;