third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.h - Issue 2004313003: DevTools: migrate from OwnPtr to std::unique_ptr for inspector protocol classes.

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.h

Issue 2004313003: DevTools: migrate from OwnPtr to std::unique_ptr for inspector protocol classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaselined Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp ('k') | third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.h

diff --git a/third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.h b/third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.h

index f5f073ddf1c7bbee4826736e1896c322d5891658..935bcf1bab9ca7af5cd6c8dd6ba42faca1ee1bb3 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.h

+++ b/third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.h

@@ -56,17 +56,17 @@ public:

void networkStateChanged(LocalFrame*, bool online);

// ApplicationCache API for InspectorFrontend

- void getFramesWithManifests(ErrorString*, OwnPtr<protocol::Array<protocol::ApplicationCache::FrameWithManifest>>* frameIds) override;

+ void getFramesWithManifests(ErrorString*, std::unique_ptr<protocol::Array<protocol::ApplicationCache::FrameWithManifest>>* frameIds) override;

void enable(ErrorString*) override;

void getManifestForFrame(ErrorString*, const String& frameId, String* manifestURL) override;

- void getApplicationCacheForFrame(ErrorString*, const String& frameId, OwnPtr<protocol::ApplicationCache::ApplicationCache>*) override;

+ void getApplicationCacheForFrame(ErrorString*, const String& frameId, std::unique_ptr<protocol::ApplicationCache::ApplicationCache>*) override;

private:

explicit InspectorApplicationCacheAgent(InspectedFrames*);

- PassOwnPtr<protocol::ApplicationCache::ApplicationCache> buildObjectForApplicationCache(const ApplicationCacheHost::ResourceInfoList&, const ApplicationCacheHost::CacheInfo&);

- PassOwnPtr<protocol::Array<protocol::ApplicationCache::ApplicationCacheResource>> buildArrayForApplicationCacheResources(const ApplicationCacheHost::ResourceInfoList&);

- PassOwnPtr<protocol::ApplicationCache::ApplicationCacheResource> buildObjectForApplicationCacheResource(const ApplicationCacheHost::ResourceInfo&);

+ std::unique_ptr<protocol::ApplicationCache::ApplicationCache> buildObjectForApplicationCache(const ApplicationCacheHost::ResourceInfoList&, const ApplicationCacheHost::CacheInfo&);

+ std::unique_ptr<protocol::Array<protocol::ApplicationCache::ApplicationCacheResource>> buildArrayForApplicationCacheResources(const ApplicationCacheHost::ResourceInfoList&);

+ std::unique_ptr<protocol::ApplicationCache::ApplicationCacheResource> buildObjectForApplicationCacheResource(const ApplicationCacheHost::ResourceInfo&);

DocumentLoader* assertFrameWithDocumentLoader(ErrorString*, String frameId);