third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp - Issue 2004313003: DevTools: migrate from OwnPtr to std::unique_ptr for inspector protocol classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp

Issue 2004313003: DevTools: migrate from OwnPtr to std::unique_ptr for inspector protocol classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaselined Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/ConsoleMessage.h ('k') | third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp

diff --git a/third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp b/third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp

index eba115dca1b37897671b3d3cd9cfa2174d8608e6..16a475c4e9568949b59974608dd23062a0fa2db2 100644

--- a/third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp

+++ b/third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp

@@ -76,7 +76,7 @@ ConsoleMessage* ConsoleMessage::create(MessageSource source, MessageLevel level,

}

// static

-ConsoleMessage* ConsoleMessage::create(MessageSource source, MessageLevel level, const String& message, const String& url, unsigned lineNumber, unsigned columnNumber, PassOwnPtr<V8StackTrace> stackTrace, int scriptId, ScriptArguments* arguments)

+ConsoleMessage* ConsoleMessage::create(MessageSource source, MessageLevel level, const String& message, const String& url, unsigned lineNumber, unsigned columnNumber, std::unique_ptr<V8StackTrace> stackTrace, int scriptId, ScriptArguments* arguments)

{

return new ConsoleMessage(source, level, message, url, lineNumber, columnNumber, std::move(stackTrace), scriptId, arguments);

}

@@ -87,7 +87,7 @@ ConsoleMessage::ConsoleMessage(MessageSource source,

const String& url,

unsigned lineNumber,

unsigned columnNumber,

- PassOwnPtr<V8StackTrace> stackTrace,

+ std::unique_ptr<V8StackTrace> stackTrace,

int scriptId,

ScriptArguments* arguments)

: m_source(source)