third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp - Issue 2004313003: DevTools: migrate from OwnPtr to std::unique_ptr for inspector protocol classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp

Issue 2004313003: DevTools: migrate from OwnPtr to std::unique_ptr for inspector protocol classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaselined Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp

index 64a4b5c5eea10841e24c3f0208c79f2c1ff5ff6e..69362fbc903b46ceab6747e2e3e4ff3e2ad558af 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp

@@ -171,13 +171,13 @@ void V8InjectedScriptHost::suppressWarningsAndCallFunctionCallback(const v8::Fun

v8::Local<v8::Function> function = info[0].As<v8::Function>();

v8::Local<v8::Value> receiver = info[1];

- OwnPtr<v8::Local<v8::Value>[]> argv = nullptr;

+ std::unique_ptr<v8::Local<v8::Value>[]> argv = nullptr;

size_t argc = 0;

if (info.Length() > 2 && info[2]->IsArray()) {

v8::Local<v8::Array> arguments = info[2].As<v8::Array>();

argc = arguments->Length();

- argv = adoptArrayPtr(new v8::Local<v8::Value>[argc]);

+ argv.reset(new v8::Local<v8::Value>[argc]);

for (size_t i = 0; i < argc; ++i) {

if (!arguments->Get(context, i).ToLocal(&argv[i]))

return;