third_party/WebKit/Source/platform/inspector_protocol/ParserTest.cpp - Issue 2004313003: DevTools: migrate from OwnPtr to std::unique_ptr for inspector protocol classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/inspector_protocol/ParserTest.cpp

Issue 2004313003: DevTools: migrate from OwnPtr to std::unique_ptr for inspector protocol classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaselined Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/inspector_protocol/Parser.cpp ('k') | third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_cpp.template » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/inspector_protocol/ParserTest.cpp

diff --git a/third_party/WebKit/Source/platform/inspector_protocol/ParserTest.cpp b/third_party/WebKit/Source/platform/inspector_protocol/ParserTest.cpp

index b6bbf0185f3bbdd0e66207d525913f973b23d349..1dfeb4a4fbb9837e1be5c75d177648ac8cfb50c6 100644

--- a/third_party/WebKit/Source/platform/inspector_protocol/ParserTest.cpp

+++ b/third_party/WebKit/Source/platform/inspector_protocol/ParserTest.cpp

@@ -14,8 +14,8 @@ namespace protocol {

TEST(ParserTest, Reading)

{

protocol::Value* tmpValue;

- OwnPtr<protocol::Value> root;

- OwnPtr<protocol::Value> root2;

+ std::unique_ptr<protocol::Value> root;

+ std::unique_ptr<protocol::Value> root2;

String16 strVal;

int intVal = 0;

@@ -495,7 +495,7 @@ TEST(ParserTest, InvalidSanity)

};

for (size_t i = 0; i < 11; ++i) {

- OwnPtr<protocol::Value> result = parseJSON(invalidJson[i]);

+ std::unique_ptr<protocol::Value> result = parseJSON(invalidJson[i]);

EXPECT_FALSE(result.get());

}