third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h - Issue 2004313003: DevTools: migrate from OwnPtr to std::unique_ptr for inspector protocol classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h

Issue 2004313003: DevTools: migrate from OwnPtr to std::unique_ptr for inspector protocol classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaselined Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h ('k') | third_party/WebKit/Source/platform/v8_inspector/public/V8ToProtocolValue.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h b/third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h

index 27438022eca6dfe6382e4ca562b8d023767158dc..11f3582c26d0822e0184a8399c2106ce62ab6b67 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h

@@ -6,7 +6,7 @@

#define V8StackTrace_h

#include "platform/inspector_protocol/TypeBuilder.h"

-#include "wtf/PassOwnPtr.h"

+#include "wtf/PtrUtil.h"

#include <v8.h>

@@ -33,9 +33,9 @@ public:

virtual String16 topFunctionName() const = 0;

virtual ~V8StackTrace() { }

- virtual PassOwnPtr<protocol::Runtime::StackTrace> buildInspectorObject() const = 0;

+ virtual std::unique_ptr<protocol::Runtime::StackTrace> buildInspectorObject() const = 0;

virtual String16 toString() const = 0;

- virtual PassOwnPtr<V8StackTrace> clone() = 0;

+ virtual std::unique_ptr<V8StackTrace> clone() = 0;

};

} // namespace blink