Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/SourceLocation.h

Issue 2004313003: DevTools: migrate from OwnPtr to std::unique_ptr for inspector protocol classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebaselined Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/SourceLocation.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/SourceLocation.h b/third_party/WebKit/Source/bindings/core/v8/SourceLocation.h
index c441b351803a9edf60c6f8661c20223927c66ba3..d15f1c948aab675a48c282c843c8a4d34ac8a9c2 100644
--- a/third_party/WebKit/Source/bindings/core/v8/SourceLocation.h
+++ b/third_party/WebKit/Source/bindings/core/v8/SourceLocation.h
@@ -25,23 +25,23 @@ public:
// Shortcut when location is unknown. Tries to capture call stack or parsing location if available.
static PassOwnPtr<SourceLocation> capture(ExecutionContext* = nullptr);
- static PassOwnPtr<SourceLocation> create(const String& url, unsigned lineNumber, unsigned columnNumber, PassOwnPtr<V8StackTrace>, int scriptId = 0);
+ static PassOwnPtr<SourceLocation> create(const String& url, unsigned lineNumber, unsigned columnNumber, std::unique_ptr<V8StackTrace>, int scriptId = 0);
~SourceLocation();
String url() const { return m_url; }
unsigned lineNumber() const { return m_lineNumber; }
unsigned columnNumber() const { return m_columnNumber; }
- PassOwnPtr<V8StackTrace> takeStackTrace() { return std::move(m_stackTrace); }
+ std::unique_ptr<V8StackTrace> takeStackTrace() { return std::move(m_stackTrace); }
int scriptId() const { return m_scriptId; }
void toTracedValue(TracedValue*, const char* name) const;
private:
- SourceLocation(const String& url, unsigned lineNumber, unsigned columnNumber, PassOwnPtr<V8StackTrace>, int scriptId);
+ SourceLocation(const String& url, unsigned lineNumber, unsigned columnNumber, std::unique_ptr<V8StackTrace>, int scriptId);
String m_url;
unsigned m_lineNumber;
unsigned m_columnNumber;
- OwnPtr<V8StackTrace> m_stackTrace;
+ std::unique_ptr<V8StackTrace> m_stackTrace;
int m_scriptId;
};

Powered by Google App Engine
This is Rietveld 408576698