third_party/WebKit/Source/core/inspector/InspectorHighlight.h - Issue 2004313003: DevTools: migrate from OwnPtr to std::unique_ptr for inspector protocol classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorHighlight.h

Issue 2004313003: DevTools: migrate from OwnPtr to std::unique_ptr for inspector protocol classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaselined Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp ('k') | third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorHighlight.h

diff --git a/third_party/WebKit/Source/core/inspector/InspectorHighlight.h b/third_party/WebKit/Source/core/inspector/InspectorHighlight.h

index 61e657fcacb815d844500ae41f7bcf36ef65fab4..892e2dc19b675b8793df2f54380dc6f27d087ef0 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorHighlight.h

+++ b/third_party/WebKit/Source/core/inspector/InspectorHighlight.h

@@ -49,21 +49,21 @@ public:

InspectorHighlight();

~InspectorHighlight();

- static bool getBoxModel(Node*, OwnPtr<protocol::DOM::BoxModel>*);

+ static bool getBoxModel(Node*, std::unique_ptr<protocol::DOM::BoxModel>*);

static InspectorHighlightConfig defaultConfig();

static bool buildNodeQuads(Node*, FloatQuad* content, FloatQuad* padding, FloatQuad* border, FloatQuad* margin);

- void appendPath(PassOwnPtr<protocol::ListValue> path, const Color& fillColor, const Color& outlineColor, const String& name = String());

+ void appendPath(std::unique_ptr<protocol::ListValue> path, const Color& fillColor, const Color& outlineColor, const String& name = String());

void appendQuad(const FloatQuad&, const Color& fillColor, const Color& outlineColor = Color::transparent, const String& name = String());

void appendEventTargetQuads(Node* eventTargetNode, const InspectorHighlightConfig&);

- PassOwnPtr<protocol::DictionaryValue> asProtocolValue() const;

+ std::unique_ptr<protocol::DictionaryValue> asProtocolValue() const;

private:

void appendNodeHighlight(Node*, const InspectorHighlightConfig&);

void appendPathsForShapeOutside(Node*, const InspectorHighlightConfig&);

- OwnPtr<protocol::DictionaryValue> m_elementInfo;

- OwnPtr<protocol::ListValue> m_highlightPaths;

+ std::unique_ptr<protocol::DictionaryValue> m_elementInfo;

+ std::unique_ptr<protocol::ListValue> m_highlightPaths;

bool m_showRulers;

bool m_showExtensionLines;

bool m_displayAsMaterial;