third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.h - Issue 2004313003: DevTools: migrate from OwnPtr to std::unique_ptr for inspector protocol classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.h

Issue 2004313003: DevTools: migrate from OwnPtr to std::unique_ptr for inspector protocol classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaselined Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h ('k') | third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.h b/third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.h

index dc0bcd1c3770f0c414daa76bd0155cc5f2d9506e..494aaadd90a37128c3db2211e4e3b570a472d6e3 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.h

@@ -9,7 +9,7 @@

#include "platform/v8_inspector/public/V8InspectorSession.h"

#include "platform/v8_inspector/public/V8InspectorSessionClient.h"

-#include "wtf/OwnPtr.h"

+#include "wtf/PtrUtil.h"

#include <v8.h>

namespace blink {

@@ -70,10 +70,10 @@ private:

void startRepeatingTimer(double, TimerCallback, void* data) override { }

void cancelTimer(void* data) override { }

- OwnPtr<V8Debugger> m_debugger;

- OwnPtr<V8InspectorSession> m_session;

- OwnPtr<protocol::Dispatcher> m_dispatcher;

- OwnPtr<protocol::Frontend> m_frontend;

+ std::unique_ptr<V8Debugger> m_debugger;

+ std::unique_ptr<V8InspectorSession> m_session;

+ std::unique_ptr<protocol::Dispatcher> m_dispatcher;

+ std::unique_ptr<protocol::Frontend> m_frontend;

};

}