third_party/WebKit/Source/core/inspector/LayoutEditor.h - Issue 2004313003: DevTools: migrate from OwnPtr to std::unique_ptr for inspector protocol classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/LayoutEditor.h

Issue 2004313003: DevTools: migrate from OwnPtr to std::unique_ptr for inspector protocol classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaselined Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp ('k') | third_party/WebKit/Source/core/inspector/LayoutEditor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/LayoutEditor.h

diff --git a/third_party/WebKit/Source/core/inspector/LayoutEditor.h b/third_party/WebKit/Source/core/inspector/LayoutEditor.h

index 1ccdffb8ce0a0d30710a51da5e53a4dff7891a6c..f4bb4c6b1f3f9272d53195a6a6ec6ca53a17a7ea 100644

--- a/third_party/WebKit/Source/core/inspector/LayoutEditor.h

+++ b/third_party/WebKit/Source/core/inspector/LayoutEditor.h

@@ -46,12 +46,12 @@ public:

private:

LayoutEditor(Element*, InspectorCSSAgent*, InspectorDOMAgent*, ScriptController*);

CSSPrimitiveValue* getPropertyCSSValue(CSSPropertyID) const;

- PassOwnPtr<protocol::DictionaryValue> createValueDescription(const String&);

+ std::unique_ptr<protocol::DictionaryValue> createValueDescription(const String&);

void appendAnchorFor(protocol::ListValue*, const String&, const String&);

bool setCSSPropertyValueInCurrentRule(const String&);

void editableSelectorUpdated(bool hasChanged) const;

- void evaluateInOverlay(const String&, PassOwnPtr<protocol::Value>) const;

- PassOwnPtr<protocol::DictionaryValue> currentSelectorInfo(CSSStyleDeclaration*) const;

+ void evaluateInOverlay(const String&, std::unique_ptr<protocol::Value>) const;

+ std::unique_ptr<protocol::DictionaryValue> currentSelectorInfo(CSSStyleDeclaration*) const;

bool growInside(String propertyName, CSSPrimitiveValue*);

Member<Element> m_element;