third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp - Issue 2004313003: DevTools: migrate from OwnPtr to std::unique_ptr for inspector protocol classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp

Issue 2004313003: DevTools: migrate from OwnPtr to std::unique_ptr for inspector protocol classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaselined Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorTracingAgent.h ('k') | third_party/WebKit/Source/core/inspector/LayoutEditor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp

index 35f60e78d64c73be005fda2a554725b690a826f9..ff5d727614ba5df9fb89924057f2ee69b8ee7b27 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp

@@ -49,7 +49,7 @@ void InspectorTracingAgent::start(ErrorString* errorString,

const Maybe<double>& bufferUsageReportingInterval,

const Maybe<String>& transferMode,

const Maybe<protocol::Tracing::TraceConfig>& config,

- PassOwnPtr<StartCallback> callback)

+ std::unique_ptr<StartCallback> callback)

{

ASSERT(sessionId().isEmpty());

if (config.isJust()) {

@@ -64,7 +64,7 @@ void InspectorTracingAgent::start(ErrorString* errorString,

callback->sendSuccess();

}

-void InspectorTracingAgent::end(ErrorString* errorString, PassOwnPtr<EndCallback> callback)

+void InspectorTracingAgent::end(ErrorString* errorString, std::unique_ptr<EndCallback> callback)

{

m_client->disableTracing();

resetSessionId();