third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h - Issue 2004313003: DevTools: migrate from OwnPtr to std::unique_ptr for inspector protocol classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h

Issue 2004313003: DevTools: migrate from OwnPtr to std::unique_ptr for inspector protocol classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaselined Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/public/V8ContentSearchUtil.h ('k') | third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h b/third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h

index 1a5e91c5fa3dc729b5f32a9526f4e824a6cf6127..d6583ed6f1a85f9134e821b4e875f376ed9e941e 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h

@@ -7,7 +7,7 @@

#include "platform/PlatformExport.h"

#include "platform/inspector_protocol/Frontend.h"

-#include "wtf/PassOwnPtr.h"

+#include "wtf/PtrUtil.h"

#include <v8.h>

@@ -25,7 +25,7 @@ class DictionaryValue;

class PLATFORM_EXPORT V8Debugger {

public:

- static PassOwnPtr<V8Debugger> create(v8::Isolate*, V8DebuggerClient*);

+ static std::unique_ptr<V8Debugger> create(v8::Isolate*, V8DebuggerClient*);

virtual ~V8Debugger() { }

// TODO(dgozman): make this non-static?

@@ -40,15 +40,15 @@ public:

virtual void idleStarted() = 0;

virtual void idleFinished() = 0;

- virtual PassOwnPtr<V8InspectorSession> connect(int contextGroupId, V8InspectorSessionClient*, const String16* state) = 0;

+ virtual std::unique_ptr<V8InspectorSession> connect(int contextGroupId, V8InspectorSessionClient*, const String16* state) = 0;

virtual bool isPaused() = 0;

static v8::Local<v8::Private> scopeExtensionPrivate(v8::Isolate*);

static bool isCommandLineAPIMethod(const String16& name);

static bool isCommandLineAPIGetter(const String16& name);

- virtual PassOwnPtr<V8StackTrace> createStackTrace(v8::Local<v8::StackTrace>, size_t maxStackSize) = 0;

- virtual PassOwnPtr<V8StackTrace> captureStackTrace(size_t maxStackSize) = 0;

+ virtual std::unique_ptr<V8StackTrace> createStackTrace(v8::Local<v8::StackTrace>, size_t maxStackSize) = 0;

+ virtual std::unique_ptr<V8StackTrace> captureStackTrace(size_t maxStackSize) = 0;

};

} // namespace blink