third_party/WebKit/Source/core/inspector/InspectorSession.h - Issue 2004313003: DevTools: migrate from OwnPtr to std::unique_ptr for inspector protocol classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorSession.h

Issue 2004313003: DevTools: migrate from OwnPtr to std::unique_ptr for inspector protocol classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaselined Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp ('k') | third_party/WebKit/Source/core/inspector/InspectorSession.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorSession.h

diff --git a/third_party/WebKit/Source/core/inspector/InspectorSession.h b/third_party/WebKit/Source/core/inspector/InspectorSession.h

index 0bef2314fdda1fc17cd917d72bf360a7570a2dd7..738bfe7bbcc2fe3e336195cd8836ffe09850bd1e 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorSession.h

+++ b/third_party/WebKit/Source/core/inspector/InspectorSession.h

@@ -83,15 +83,15 @@ private:

bool isInstrumenting();

Client* m_client;

- OwnPtr<V8InspectorSession> m_v8Session;

+ std::unique_ptr<V8InspectorSession> m_v8Session;

int m_sessionId;

bool m_autoFlush;

bool m_disposed;

Member<InspectedFrames> m_inspectedFrames;

Member<InstrumentingAgents> m_instrumentingAgents;

- OwnPtr<protocol::Frontend> m_inspectorFrontend;

- OwnPtr<protocol::Dispatcher> m_inspectorBackendDispatcher;

- OwnPtr<protocol::DictionaryValue> m_state;

+ std::unique_ptr<protocol::Frontend> m_inspectorFrontend;

+ std::unique_ptr<protocol::Dispatcher> m_inspectorBackendDispatcher;

+ std::unique_ptr<protocol::DictionaryValue> m_state;

HeapVector<Member<InspectorAgent>> m_agents;

Vector<protocol::String16> m_notificationQueue;

String m_lastSentState;