third_party/WebKit/Source/platform/inspector_protocol/Backend_h.template - Issue 2004313003: DevTools: migrate from OwnPtr to std::unique_ptr for inspector protocol classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/inspector_protocol/Backend_h.template

Issue 2004313003: DevTools: migrate from OwnPtr to std::unique_ptr for inspector protocol classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaselined Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/inspector_protocol/Array.h ('k') | third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/inspector_protocol/Backend_h.template

diff --git a/third_party/WebKit/Source/platform/inspector_protocol/Backend_h.template b/third_party/WebKit/Source/platform/inspector_protocol/Backend_h.template

index 2ab74d485229f4468f9a9a1a6fcb9953e0a20672..4d6ac711f6dfaca489d57fb9a29cd3b848144292 100644

--- a/third_party/WebKit/Source/platform/inspector_protocol/Backend_h.template

+++ b/third_party/WebKit/Source/platform/inspector_protocol/Backend_h.template

@@ -53,7 +53,7 @@ public:

{%- endif -%}

{%- endfor -%}

{%- if "async" in command -%}

- , PassOwnPtr<{{command.name | to_title_case}}Callback> callback

+ , std::unique_ptr<{{command.name | to_title_case}}Callback> callback

{%- else -%}

{%- for parameter in command.returns -%}

{%- if "optional" in parameter -%}