ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom

ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom

There are several places where DCHECK_{EQ/NE} can not be used because
"operator<<(ostream&, T&)" is not defined for T.

To isolate issues, other macros, such as RELEASE_ASSERT, will be replaced in another CL.

BUG=596760, 601669
Committed: https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446
Cr-Commit-Position: refs/heads/master@{#385971}

[hayato, 2016-04-05 06:00:38]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-05 06:01:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1854423002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1854423002/1

[commit-bot: I haz the power, 2016-04-05 06:15:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 06:15:59]

Dry run: Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[hayato, 2016-04-05 06:30:34]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[hayato, 2016-04-05 06:30:41]

wip

[commit-bot: I haz the power, 2016-04-05 06:30:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1854423002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1854423002/20001

[commit-bot: I haz the power, 2016-04-05 06:43:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 06:43:42]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[hayato, 2016-04-05 11:14:43]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-05 11:14:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1854423002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1854423002/40001

[hayato, 2016-04-05 11:14:51]

wip

[commit-bot: I haz the power, 2016-04-05 11:28:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 11:28:50]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[hayato, 2016-04-05 12:03:14]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[hayato, 2016-04-05 12:03:18]

wip

[commit-bot: I haz the power, 2016-04-05 12:03:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1854423002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1854423002/60001

[hayato, 2016-04-05 12:08:07]

Description was changed from

==========
ASSERT -> DCHECK in dom

BUG=596760
==========

to

==========
ASSERT -> DCHECK in dom

There are several places where DCHECK_{EQ/NE} can not be used because
"operator<<(ostream&, T)" is not defined for T.

BUG=596760
==========

[hayato, 2016-04-05 12:08:07]

hayato@chromium.org changed reviewers:
+ kochi@chromium.org, tkent@chromium.org

[hayato, 2016-04-05 12:09:08]

Description was changed from

==========
ASSERT -> DCHECK in dom

There are several places where DCHECK_{EQ/NE} can not be used because
"operator<<(ostream&, T)" is not defined for T.

BUG=596760
==========

to

==========
ASSERT -> {DCHECK|DCHECK_XX} in dom

There are several places where DCHECK_{EQ/NE} can not be used because
"operator<<(ostream&, T)" is not defined for T.

BUG=596760
==========

[hayato, 2016-04-05 12:09:34]

Description was changed from

==========
ASSERT -> {DCHECK|DCHECK_XX} in dom

There are several places where DCHECK_{EQ/NE} can not be used because
"operator<<(ostream&, T)" is not defined for T.

BUG=596760
==========

to

==========
ASSERT -> {DCHECK|DCHECK_XX} in dom

There are several places where DCHECK_{EQ/NE} can not be used because
"operator<<(ostream&, T&)" is not defined for T.

BUG=596760
==========

[commit-bot: I haz the power, 2016-04-05 12:23:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 12:23:44]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[hayato, 2016-04-05 12:37:13]

Description was changed from

==========
ASSERT -> {DCHECK|DCHECK_XX} in dom

There are several places where DCHECK_{EQ/NE} can not be used because
"operator<<(ostream&, T&)" is not defined for T.

BUG=596760
==========

to

==========
ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom

There are several places where DCHECK_{EQ/NE} can not be used because
"operator<<(ostream&, T&)" is not defined for T.

BUG=596760
==========

[hayato, 2016-04-05 12:43:31]

Description was changed from

==========
ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom

There are several places where DCHECK_{EQ/NE} can not be used because
"operator<<(ostream&, T&)" is not defined for T.

BUG=596760
==========

to

==========
ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom

There are several places where DCHECK_{EQ/NE} can not be used because
"operator<<(ostream&, T&)" is not defined for T.

Other kinds of macros, such as RELEASE_ASSERT, will be replaced in another CL.

BUG=596760
==========

[hayato, 2016-04-05 12:43:46]

Description was changed from

==========
ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom

There are several places where DCHECK_{EQ/NE} can not be used because
"operator<<(ostream&, T&)" is not defined for T.

Other kinds of macros, such as RELEASE_ASSERT, will be replaced in another CL.

BUG=596760
==========

to

==========
ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom

There are several places where DCHECK_{EQ/NE} can not be used because
"operator<<(ostream&, T&)" is not defined for T.

Other macros, such as RELEASE_ASSERT, will be replaced in another CL.

BUG=596760
==========

[hayato, 2016-04-05 12:44:26]

Description was changed from

==========
ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom

There are several places where DCHECK_{EQ/NE} can not be used because
"operator<<(ostream&, T&)" is not defined for T.

Other macros, such as RELEASE_ASSERT, will be replaced in another CL.

BUG=596760
==========

to

==========
ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom

There are several places where DCHECK_{EQ/NE} can not be used because
"operator<<(ostream&, T&)" is not defined for T.

To isolate issues, other macros, such as RELEASE_ASSERT, will be replaced in
another CL.

BUG=596760
==========

[hayato, 2016-04-05 12:45:36]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[hayato, 2016-04-05 12:45:46]

ENABLE(ASSERT) -> Use DCHECK_IS_ON

[commit-bot: I haz the power, 2016-04-05 12:45:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1854423002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1854423002/80001

[commit-bot: I haz the power, 2016-04-05 13:00:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 13:00:37]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[hayato, 2016-04-05 13:23:43]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[hayato, 2016-04-05 13:23:47]

guard by DCHECK_IS_ON

[commit-bot: I haz the power, 2016-04-05 13:23:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1854423002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1854423002/100001

[hayato, 2016-04-05 13:50:50]

See
https://groups.google.com/a/chromium.org/d/msg/blink-dev/TL0NkNXIT1w/ZU4509xp...
also why I have to guard DCHECK by DCHECK_IS_ON at some places.

[commit-bot: I haz the power, 2016-04-05 14:41:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 14:41:33]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[kochi, 2016-04-06 04:47:00]

rs LGTM

[hayato, 2016-04-06 05:28:25]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[hayato, 2016-04-06 05:28:35]

fix a wrong replacement

[commit-bot: I haz the power, 2016-04-06 05:28:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1854423002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1854423002/120001

[hayato, 2016-04-06 05:28:59]

The CQ bit was unchecked by hayato@chromium.org

[hayato, 2016-04-06 05:29:04]

The CQ bit was checked by hayato@chromium.org

[hayato, 2016-04-06 05:29:05]

The patchset sent to the CQ was uploaded after l-g-t-m from kochi@chromium.org
Link to the patchset: https://codereview.chromium.org/1854423002/#ps120001
(title: "fix a wrong replacement")

[commit-bot: I haz the power, 2016-04-06 05:29:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1854423002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1854423002/120001

[commit-bot: I haz the power, 2016-04-06 07:51:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 07:51:39]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[hayato, 2016-04-06 08:01:03]

The CQ bit was checked by hayato@chromium.org

[commit-bot: I haz the power, 2016-04-06 08:01:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1854423002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1854423002/120001

[commit-bot: I haz the power, 2016-04-06 09:26:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 09:26:53]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[hayato, 2016-04-07 03:44:41]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[hayato, 2016-04-07 03:44:52]

rebased

[commit-bot: I haz the power, 2016-04-07 03:45:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1854423002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1854423002/140001

[hayato, 2016-04-07 03:45:18]

The CQ bit was unchecked by hayato@chromium.org

[hayato, 2016-04-07 03:45:21]

The CQ bit was checked by hayato@chromium.org

[hayato, 2016-04-07 03:45:22]

The patchset sent to the CQ was uploaded after l-g-t-m from kochi@chromium.org
Link to the patchset: https://codereview.chromium.org/1854423002/#ps140001
(title: "rebased")

[commit-bot: I haz the power, 2016-04-07 03:45:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1854423002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1854423002/140001

[commit-bot: I haz the power, 2016-04-07 05:04:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 05:04:38]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[hayato, 2016-04-07 05:09:51]

The CQ bit was checked by hayato@chromium.org

[commit-bot: I haz the power, 2016-04-07 05:10:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1854423002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1854423002/140001

[commit-bot: I haz the power, 2016-04-07 07:43:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 07:43:15]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[hayato, 2016-04-07 08:56:05]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[hayato, 2016-04-07 08:56:22]

rebase again

[commit-bot: I haz the power, 2016-04-07 08:56:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1854423002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1854423002/160001

[hayato, 2016-04-07 08:56:31]

The CQ bit was unchecked by hayato@chromium.org

[hayato, 2016-04-07 08:56:35]

The CQ bit was checked by hayato@chromium.org

[hayato, 2016-04-07 08:56:36]

The patchset sent to the CQ was uploaded after l-g-t-m from kochi@chromium.org
Link to the patchset: https://codereview.chromium.org/1854423002/#ps160001
(title: "rebase again")

[commit-bot: I haz the power, 2016-04-07 08:56:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1854423002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1854423002/160001

[commit-bot: I haz the power, 2016-04-07 11:50:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 11:50:06]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[kochi, 2016-04-08 00:47:23]

The CQ bit was checked by kochi@chromium.org

[commit-bot: I haz the power, 2016-04-08 00:47:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1854423002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1854423002/160001

[commit-bot: I haz the power, 2016-04-08 00:58:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-08 00:58:06]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[hayato, 2016-04-08 01:34:21]

Description was changed from

==========
ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom

There are several places where DCHECK_{EQ/NE} can not be used because
"operator<<(ostream&, T&)" is not defined for T.

To isolate issues, other macros, such as RELEASE_ASSERT, will be replaced in
another CL.

BUG=596760
==========

to

==========
ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom

There are several places where DCHECK_{EQ/NE} can not be used because
"operator<<(ostream&, T&)" is not defined for T.

To isolate issues, other macros, such as RELEASE_ASSERT, will be replaced in
another CL.

BUG=596760,601669
==========

[hayato, 2016-04-08 01:36:37]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[hayato, 2016-04-08 01:36:44]

mark svg/as-image/svg-nested.html crash on win

[hayato, 2016-04-08 01:37:02]

The CQ bit was unchecked by hayato@chromium.org

[hayato, 2016-04-08 01:37:06]

The CQ bit was checked by hayato@chromium.org

[hayato, 2016-04-08 01:37:07]

The patchset sent to the CQ was uploaded after l-g-t-m from kochi@chromium.org
Link to the patchset: https://codereview.chromium.org/1854423002/#ps180001
(title: "mark svg/as-image/svg-nested.html crash on win")

[commit-bot: I haz the power, 2016-04-08 01:37:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1854423002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1854423002/180001

[commit-bot: I haz the power, 2016-04-08 03:15:23]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2016-04-08 03:17:10]

Description was changed from

==========
ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom

There are several places where DCHECK_{EQ/NE} can not be used because
"operator<<(ostream&, T&)" is not defined for T.

To isolate issues, other macros, such as RELEASE_ASSERT, will be replaced in
another CL.

BUG=596760,601669
==========

to

==========
ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom

There are several places where DCHECK_{EQ/NE} can not be used because
"operator<<(ostream&, T&)" is not defined for T.

To isolate issues, other macros, such as RELEASE_ASSERT, will be replaced in
another CL.

BUG=596760,601669

Committed: https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446
Cr-Commit-Position: refs/heads/master@{#385971}
==========

[commit-bot: I haz the power, 2016-04-08 03:17:13]

Patchset 10 (id:??) landed as
https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446
Cr-Commit-Position: refs/heads/master@{#385971}