third_party/WebKit/Source/core/dom/SecurityContext.cpp - Issue 1854423002: ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/SecurityContext.cpp

Issue 1854423002: ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mark svg/as-image/svg-nested.html crash on win Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp ('k') | third_party/WebKit/Source/core/dom/SelectorQuery.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/SecurityContext.cpp

diff --git a/third_party/WebKit/Source/core/dom/SecurityContext.cpp b/third_party/WebKit/Source/core/dom/SecurityContext.cpp

index 4652a683093438531931d14cf1cb5d36bab7b73a..fe0af6e8af7fc9878d8d9779bfb86a254f9f7824 100644

--- a/third_party/WebKit/Source/core/dom/SecurityContext.cpp

+++ b/third_party/WebKit/Source/core/dom/SecurityContext.cpp

@@ -99,10 +99,10 @@ void SecurityContext::enforceSuborigin(const Suborigin& suborigin)

if (!RuntimeEnabledFeatures::suboriginsEnabled())

return;

- ASSERT(!suborigin.name().isEmpty());

- ASSERT(RuntimeEnabledFeatures::suboriginsEnabled());

- ASSERT(m_securityOrigin.get());

- ASSERT(!m_securityOrigin->hasSuborigin() || m_securityOrigin->suborigin()->name() == suborigin.name());

+ DCHECK(!suborigin.name().isEmpty());

+ DCHECK(RuntimeEnabledFeatures::suboriginsEnabled());

+ DCHECK(m_securityOrigin.get());

+ DCHECK(!m_securityOrigin->hasSuborigin() || m_securityOrigin->suborigin()->name() == suborigin.name());

m_securityOrigin->addSuborigin(suborigin);

didUpdateSecurityOrigin();

}