third_party/WebKit/Source/core/dom/custom/CustomElement.cpp - Issue 1854423002: ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElement.cpp

Issue 1854423002: ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mark svg/as-image/svg-nested.html crash on win Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/WeakIdentifierMap.h ('k') | third_party/WebKit/Source/core/dom/custom/CustomElementCallbackInvocation.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/custom/CustomElement.cpp

diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElement.cpp b/third_party/WebKit/Source/core/dom/custom/CustomElement.cpp

index b60e60c91b5b7be91521bb24ab5932663304d111..c007a9fd78afb77037ec188220e4e7c61ecc3af8 100644

--- a/third_party/WebKit/Source/core/dom/custom/CustomElement.cpp

+++ b/third_party/WebKit/Source/core/dom/custom/CustomElement.cpp

@@ -121,13 +121,13 @@ void CustomElement::define(Element* element, RawPtr<CustomElementDefinition> pas

void CustomElement::attributeDidChange(Element* element, const AtomicString& name, const AtomicString& oldValue, const AtomicString& newValue)

{

- ASSERT(element->getCustomElementState() == Element::Upgraded);

+ DCHECK_EQ(element->getCustomElementState(), Element::Upgraded);

CustomElementScheduler::scheduleAttributeChangedCallback(element->customElementDefinition()->callbacks(), element, name, oldValue, newValue);

}

void CustomElement::didAttach(Element* element, const Document& document)

{

- ASSERT(element->getCustomElementState() == Element::Upgraded);

+ DCHECK_EQ(element->getCustomElementState(), Element::Upgraded);

if (!document.domWindow())

return;

CustomElementScheduler::scheduleCallback(element->customElementDefinition()->callbacks(), element, CustomElementLifecycleCallbacks::AttachedCallback);

@@ -135,7 +135,7 @@ void CustomElement::didAttach(Element* element, const Document& document)

void CustomElement::didDetach(Element* element, const Document& document)

{

- ASSERT(element->getCustomElementState() == Element::Upgraded);

+ DCHECK_EQ(element->getCustomElementState(), Element::Upgraded);

if (!document.domWindow())

return;

CustomElementScheduler::scheduleCallback(element->customElementDefinition()->callbacks(), element, CustomElementLifecycleCallbacks::DetachedCallback);