Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: third_party/WebKit/Source/core/dom/ScriptRunner.cpp

Issue 1854423002: ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mark svg/as-image/svg-nested.html crash on win Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/ScriptRunner.cpp
diff --git a/third_party/WebKit/Source/core/dom/ScriptRunner.cpp b/third_party/WebKit/Source/core/dom/ScriptRunner.cpp
index 3c67e0fb945ca530f448dfecb1f50944f4b97d07..83452474274ac013a30917f6a4027c8016d1dfac 100644
--- a/third_party/WebKit/Source/core/dom/ScriptRunner.cpp
+++ b/third_party/WebKit/Source/core/dom/ScriptRunner.cpp
@@ -46,7 +46,7 @@ ScriptRunner::ScriptRunner(Document* document)
, m_weakPointerFactoryForTasks(this)
#endif
{
- ASSERT(document);
+ DCHECK(document);
#ifndef NDEBUG
m_hasEverBeenSuspended = false;
#endif
@@ -83,7 +83,7 @@ void ScriptRunner::dispose()
void ScriptRunner::queueScriptForExecution(ScriptLoader* scriptLoader, ExecutionType executionType)
{
- ASSERT(scriptLoader);
+ DCHECK(scriptLoader);
m_document->incrementLoadEventDelayCount();
switch (executionType) {
case ASYNC_EXECUTION:
@@ -117,7 +117,7 @@ void ScriptRunner::suspend()
void ScriptRunner::resume()
{
- ASSERT(m_isSuspended);
+ DCHECK(m_isSuspended);
m_isSuspended = false;
@@ -225,12 +225,12 @@ void ScriptRunner::movePendingScript(Document& oldDocument, Document& newDocumen
// The script element's loader is in that case moved to document() and
// its script runner, which is the non-null Document that contextDocument()
// would return if not detached.
- ASSERT(!newDocument.frame());
+ DCHECK(!newDocument.frame());
newContextDocument = &newDocument;
}
RawPtr<Document> oldContextDocument = oldDocument.contextDocument().get();
if (!oldContextDocument) {
- ASSERT(!oldDocument.frame());
+ DCHECK(!oldDocument.frame());
oldContextDocument = &oldDocument;
}
if (oldContextDocument != newContextDocument)
@@ -275,7 +275,7 @@ void ScriptRunner::executeTask()
#ifndef NDEBUG
// Extra tasks should be posted only when we resume after suspending.
- ASSERT(m_hasEverBeenSuspended);
+ DCHECK(m_hasEverBeenSuspended);
#endif
}

Powered by Google App Engine
This is Rietveld 408576698