third_party/WebKit/Source/core/dom/URLSearchParams.cpp - Issue 1854423002: ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/URLSearchParams.cpp

Issue 1854423002: ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mark svg/as-image/svg-nested.html crash on win Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/TypedFlexibleArrayBufferView.h ('k') | third_party/WebKit/Source/core/dom/UserActionElementSet.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/URLSearchParams.cpp

diff --git a/third_party/WebKit/Source/core/dom/URLSearchParams.cpp b/third_party/WebKit/Source/core/dom/URLSearchParams.cpp

index bb2d8be6a3de5ac37505b24288b8f3d6c6cd2cdc..906ec4cbf22a54e4a2db64fd7d62727a70f771d6 100644

--- a/third_party/WebKit/Source/core/dom/URLSearchParams.cpp

+++ b/third_party/WebKit/Source/core/dom/URLSearchParams.cpp

@@ -42,7 +42,7 @@ URLSearchParams* URLSearchParams::create(const URLSearchParamsInit& init)

if (init.isURLSearchParams())

return new URLSearchParams(init.getAsURLSearchParams());

- ASSERT(init.isNull());

+ DCHECK(init.isNull());

return new URLSearchParams(String());

}

@@ -54,7 +54,7 @@ URLSearchParams::URLSearchParams(const String& queryString)

URLSearchParams::URLSearchParams(URLSearchParams* searchParams)

{

- ASSERT(searchParams);

+ DCHECK(searchParams);

m_params = searchParams->m_params;

}

@@ -69,7 +69,7 @@ static String decodeString(String input)

void URLSearchParams::setInput(const String& queryString)

{

- ASSERT(m_params.isEmpty());

+ DCHECK(m_params.isEmpty());

size_t start = 0;

size_t queryStringLength = queryString.length();

while (start < queryStringLength) {