Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: third_party/WebKit/Source/core/dom/custom/CustomElementProcessingStack.cpp

Issue 1854423002: ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mark svg/as-image/svg-nested.html crash on win Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 } 47 }
48 48
49 // Dispatches callbacks when popping the processing stack. 49 // Dispatches callbacks when popping the processing stack.
50 void CustomElementProcessingStack::processElementQueueAndPop() 50 void CustomElementProcessingStack::processElementQueueAndPop()
51 { 51 {
52 instance().processElementQueueAndPop(s_elementQueueStart, s_elementQueueEnd) ; 52 instance().processElementQueueAndPop(s_elementQueueStart, s_elementQueueEnd) ;
53 } 53 }
54 54
55 void CustomElementProcessingStack::processElementQueueAndPop(size_t start, size_ t end) 55 void CustomElementProcessingStack::processElementQueueAndPop(size_t start, size_ t end)
56 { 56 {
57 ASSERT(isMainThread()); 57 DCHECK(isMainThread());
58 CustomElementCallbackQueue::ElementQueueId thisQueue = currentElementQueue() ; 58 CustomElementCallbackQueue::ElementQueueId thisQueue = currentElementQueue() ;
59 59
60 for (size_t i = start; i < end; ++i) { 60 for (size_t i = start; i < end; ++i) {
61 { 61 {
62 // The created callback may schedule entered document 62 // The created callback may schedule entered document
63 // callbacks. 63 // callbacks.
64 CallbackDeliveryScope deliveryScope; 64 CallbackDeliveryScope deliveryScope;
65 m_flattenedProcessingStack[i]->processInElementQueue(thisQueue); 65 m_flattenedProcessingStack[i]->processInElementQueue(thisQueue);
66 } 66 }
67 67
68 ASSERT(start == s_elementQueueStart); 68 DCHECK_EQ(start, s_elementQueueStart);
69 ASSERT(end == s_elementQueueEnd); 69 DCHECK_EQ(end, s_elementQueueEnd);
70 } 70 }
71 71
72 // Pop the element queue from the processing stack 72 // Pop the element queue from the processing stack
73 m_flattenedProcessingStack.resize(start); 73 m_flattenedProcessingStack.resize(start);
74 s_elementQueueEnd = start; 74 s_elementQueueEnd = start;
75 75
76 if (s_elementQueueStart == kNumSentinels) 76 if (s_elementQueueStart == kNumSentinels)
77 CustomElementScheduler::callbackDispatcherDidFinish(); 77 CustomElementScheduler::callbackDispatcherDidFinish();
78 } 78 }
79 79
80 void CustomElementProcessingStack::enqueue(CustomElementCallbackQueue* callbackQ ueue) 80 void CustomElementProcessingStack::enqueue(CustomElementCallbackQueue* callbackQ ueue)
81 { 81 {
82 ASSERT(inCallbackDeliveryScope()); 82 DCHECK(inCallbackDeliveryScope());
83 83
84 if (callbackQueue->owner() == currentElementQueue()) 84 if (callbackQueue->owner() == currentElementQueue())
85 return; 85 return;
86 86
87 callbackQueue->setOwner(currentElementQueue()); 87 callbackQueue->setOwner(currentElementQueue());
88 88
89 m_flattenedProcessingStack.append(callbackQueue); 89 m_flattenedProcessingStack.append(callbackQueue);
90 ++s_elementQueueEnd; 90 ++s_elementQueueEnd;
91 } 91 }
92 92
93 DEFINE_TRACE(CustomElementProcessingStack) 93 DEFINE_TRACE(CustomElementProcessingStack)
94 { 94 {
95 visitor->trace(m_flattenedProcessingStack); 95 visitor->trace(m_flattenedProcessingStack);
96 } 96 }
97 97
98 } // namespace blink 98 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698