Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: third_party/WebKit/Source/core/dom/custom/CustomElementProcessingStack.h

Issue 1854423002: ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mark svg/as-image/svg-nested.html crash on win Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 CustomElementProcessingStack() 72 CustomElementProcessingStack()
73 { 73 {
74 // Add a null element as a sentinel. This makes it possible to 74 // Add a null element as a sentinel. This makes it possible to
75 // identify elements queued when there is no 75 // identify elements queued when there is no
76 // CallbackDeliveryScope active. Also, if the processing stack 76 // CallbackDeliveryScope active. Also, if the processing stack
77 // is popped when empty, this sentinel will cause a null deref 77 // is popped when empty, this sentinel will cause a null deref
78 // crash. 78 // crash.
79 CustomElementCallbackQueue* sentinel = 0; 79 CustomElementCallbackQueue* sentinel = 0;
80 for (size_t i = 0; i < kNumSentinels; i++) 80 for (size_t i = 0; i < kNumSentinels; i++)
81 m_flattenedProcessingStack.append(sentinel); 81 m_flattenedProcessingStack.append(sentinel);
82 ASSERT(s_elementQueueEnd == m_flattenedProcessingStack.size()); 82 DCHECK_EQ(s_elementQueueEnd, m_flattenedProcessingStack.size());
83 } 83 }
84 84
85 // The start of the element queue on the top of the processing 85 // The start of the element queue on the top of the processing
86 // stack. An offset into instance().m_flattenedProcessingStack. 86 // stack. An offset into instance().m_flattenedProcessingStack.
87 static size_t s_elementQueueStart; 87 static size_t s_elementQueueStart;
88 88
89 // The end of the element queue on the top of the processing 89 // The end of the element queue on the top of the processing
90 // stack. A cache of instance().m_flattenedProcessingStack.size(). 90 // stack. A cache of instance().m_flattenedProcessingStack.size().
91 static size_t s_elementQueueEnd; 91 static size_t s_elementQueueEnd;
92 92
93 static CustomElementCallbackQueue::ElementQueueId currentElementQueue() { re turn CustomElementCallbackQueue::ElementQueueId(s_elementQueueStart); } 93 static CustomElementCallbackQueue::ElementQueueId currentElementQueue() { re turn CustomElementCallbackQueue::ElementQueueId(s_elementQueueStart); }
94 94
95 static void processElementQueueAndPop(); 95 static void processElementQueueAndPop();
96 void processElementQueueAndPop(size_t start, size_t end); 96 void processElementQueueAndPop(size_t start, size_t end);
97 97
98 // The processing stack, flattened. Element queues lower in the 98 // The processing stack, flattened. Element queues lower in the
99 // stack appear toward the head of the vector. The first element 99 // stack appear toward the head of the vector. The first element
100 // is a null sentinel value. 100 // is a null sentinel value.
101 static const size_t kNumSentinels = 1; 101 static const size_t kNumSentinels = 1;
102 HeapVector<Member<CustomElementCallbackQueue>> m_flattenedProcessingStack; 102 HeapVector<Member<CustomElementCallbackQueue>> m_flattenedProcessingStack;
103 }; 103 };
104 104
105 } // namespace blink 105 } // namespace blink
106 106
107 #endif // CustomElementProcessingStack_h 107 #endif // CustomElementProcessingStack_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698