third_party/WebKit/Source/core/dom/SpaceSplitString.cpp - Issue 1854423002: ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/SpaceSplitString.cpp

Issue 1854423002: ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mark svg/as-image/svg-nested.html crash on win Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/ShadowTreeStyleSheetCollection.cpp ('k') | third_party/WebKit/Source/core/dom/StyleChangeReason.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/SpaceSplitString.cpp

diff --git a/third_party/WebKit/Source/core/dom/SpaceSplitString.cpp b/third_party/WebKit/Source/core/dom/SpaceSplitString.cpp

index 41baeab23bbf94f562531c23ca345b6ff16d7d84..3edd3acf7d3b8b175f889eabc9490cded49c140a 100644

--- a/third_party/WebKit/Source/core/dom/SpaceSplitString.cpp

+++ b/third_party/WebKit/Source/core/dom/SpaceSplitString.cpp

@@ -104,14 +104,14 @@ bool SpaceSplitString::Data::containsAll(Data& other)

void SpaceSplitString::Data::add(const AtomicString& string)

{

- ASSERT(hasOneRef());

- ASSERT(!contains(string));

+ DCHECK(hasOneRef());

+ DCHECK(!contains(string));

m_vector.append(string);

}

void SpaceSplitString::Data::remove(unsigned index)

{

- ASSERT(hasOneRef());

+ DCHECK(hasOneRef());

m_vector.remove(index);

}

@@ -190,7 +190,7 @@ PassRefPtr<SpaceSplitString::Data> SpaceSplitString::Data::createUnique(const Da

SpaceSplitString::Data::Data(const AtomicString& string)

: m_keyString(string)

{

- ASSERT(!string.isNull());

+ DCHECK(!string.isNull());

createVector(string);

}