third_party/WebKit/Source/core/dom/CharacterData.h - Issue 1854423002: ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/CharacterData.h

Issue 1854423002: ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mark svg/as-image/svg-nested.html crash on win Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/CSSSelectorWatch.cpp ('k') | third_party/WebKit/Source/core/dom/CharacterData.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/CharacterData.h

diff --git a/third_party/WebKit/Source/core/dom/CharacterData.h b/third_party/WebKit/Source/core/dom/CharacterData.h

index 15b96f11f7c014c1e78e8a294f2d10a05733f9b7..5c9c9466712412e8f374766f13cdcf40da8c8f6a 100644

--- a/third_party/WebKit/Source/core/dom/CharacterData.h

+++ b/third_party/WebKit/Source/core/dom/CharacterData.h

@@ -57,12 +57,12 @@ protected:

: Node(&treeScope, type)

, m_data(!text.isNull() ? text : emptyString())

{

- ASSERT(type == CreateOther || type == CreateText || type == CreateEditingText);

+ DCHECK(type == CreateOther || type == CreateText || type == CreateEditingText);

}

void setDataWithoutUpdate(const String& data)

{

- ASSERT(!data.isNull());

+ DCHECK(!data.isNull());

m_data = data;

}

enum UpdateSource {

« no previous file with comments | « third_party/WebKit/Source/core/dom/CSSSelectorWatch.cpp ('k') | third_party/WebKit/Source/core/dom/CharacterData.cpp » ('j') | no next file with comments »