Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementScheduler.cpp

Issue 1854423002: ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mark svg/as-image/svg-nested.html crash on win Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/custom/CustomElementScheduler.cpp
diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementScheduler.cpp b/third_party/WebKit/Source/core/dom/custom/CustomElementScheduler.cpp
index 0a6e03c0770845d2909c3d306ecf6667d98dd505..7c92144b448b966995f7cef6dbfc6fa4206330b6 100644
--- a/third_party/WebKit/Source/core/dom/custom/CustomElementScheduler.cpp
+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementScheduler.cpp
@@ -89,7 +89,7 @@ static CustomElementCallbackQueue& scheduleCallbackQueue(RawPtr<Element> passEle
void CustomElementScheduler::scheduleCallback(RawPtr<CustomElementLifecycleCallbacks> callbacks, RawPtr<Element> element, CustomElementLifecycleCallbacks::CallbackType type)
{
- ASSERT(type != CustomElementLifecycleCallbacks::AttributeChangedCallback);
+ DCHECK(type != CustomElementLifecycleCallbacks::AttributeChangedCallback);
if (!callbacks->hasCallback(type))
return;
@@ -121,8 +121,8 @@ void CustomElementScheduler::resolveOrScheduleResolution(RawPtr<CustomElementReg
CustomElementMicrotaskImportStep* CustomElementScheduler::scheduleImport(HTMLImportChild* import)
{
- ASSERT(!import->hasFinishedLoading());
- ASSERT(import->parent());
+ DCHECK(!import->hasFinishedLoading());
+ DCHECK(import->parent());
// Ownership of the new step is transferred to the parent
// processing step, or the base queue.
@@ -147,7 +147,7 @@ void CustomElementScheduler::callbackDispatcherDidFinish()
void CustomElementScheduler::microtaskDispatcherDidFinish()
{
- ASSERT(!CustomElementProcessingStack::inCallbackDeliveryScope());
+ DCHECK(!CustomElementProcessingStack::inCallbackDeliveryScope());
callbackQueues().clear();
}

Powered by Google App Engine
This is Rietveld 408576698