third_party/WebKit/Source/core/dom/NamedNodeMap.cpp - Issue 1854423002: ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/NamedNodeMap.cpp

Issue 1854423002: ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mark svg/as-image/svg-nested.html crash on win Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/dom/NamedNodeMap.cpp

diff --git a/third_party/WebKit/Source/core/dom/NamedNodeMap.cpp b/third_party/WebKit/Source/core/dom/NamedNodeMap.cpp

index d7d5ec53d34f1133bdbac389c067e39e55e71feb..a622c811e31c65c253f9389c67e3d86c97b64ef0 100644

--- a/third_party/WebKit/Source/core/dom/NamedNodeMap.cpp

+++ b/third_party/WebKit/Source/core/dom/NamedNodeMap.cpp

@@ -77,13 +77,13 @@ RawPtr<Attr> NamedNodeMap::removeNamedItemNS(const AtomicString& namespaceURI, c

RawPtr<Attr> NamedNodeMap::setNamedItem(Attr* attr, ExceptionState& exceptionState)

{

- ASSERT(attr);

+ DCHECK(attr);

return m_element->setAttributeNode(attr, exceptionState);

}

RawPtr<Attr> NamedNodeMap::setNamedItemNS(Attr* attr, ExceptionState& exceptionState)

{

- ASSERT(attr);

+ DCHECK(attr);

return m_element->setAttributeNodeNS(attr, exceptionState);

}

« no previous file with comments | « third_party/WebKit/Source/core/dom/NamedNodeMap.h ('k') | third_party/WebKit/Source/core/dom/Node.h » ('j') | no next file with comments »