third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp - Issue 1854423002: ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp

Issue 1854423002: ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mark svg/as-image/svg-nested.html crash on win Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/LayoutTreeBuilder.h ('k') | third_party/WebKit/Source/core/dom/LayoutTreeBuilderTraversal.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp

diff --git a/third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp b/third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp

index 12e151d1fb21f9575a4766a5bb8af292cc950b1f..1beefc59f081cdc3dd9ed35db85f899fe3199923 100644

--- a/third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp

+++ b/third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp

@@ -47,7 +47,7 @@ LayoutTreeBuilderForElement::LayoutTreeBuilderForElement(Element& element, Compu

: LayoutTreeBuilder(element, nullptr)

, m_style(style)

{

- ASSERT(!element.isSlotOrActiveInsertionPoint());

+ DCHECK(!element.isSlotOrActiveInsertionPoint());

if (element.isFirstLetterPseudoElement()) {

if (LayoutObject* nextLayoutObject = FirstLetterPseudoElement::firstLetterTextLayoutObject(element))

m_layoutObjectParent = nextLayoutObject->parent();

@@ -58,7 +58,7 @@ LayoutTreeBuilderForElement::LayoutTreeBuilderForElement(Element& element, Compu

LayoutObject* LayoutTreeBuilderForElement::nextLayoutObject() const

{

- ASSERT(m_layoutObjectParent);

+ DCHECK(m_layoutObjectParent);

if (m_node->isInTopLayer())

return LayoutTreeBuilderTraversal::nextInTopLayer(*m_node);

@@ -149,7 +149,7 @@ void LayoutTreeBuilderForText::createLayoutObject()

{

ComputedStyle& style = m_layoutObjectParent->mutableStyleRef();

- ASSERT(m_node->textLayoutObjectIsNeeded(style, *m_layoutObjectParent));

+ DCHECK(m_node->textLayoutObjectIsNeeded(style, *m_layoutObjectParent));

LayoutText* newLayoutObject = m_node->createTextLayoutObject(style);

if (!m_layoutObjectParent->isChildAllowed(newLayoutObject, style)) {