Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: third_party/WebKit/Source/core/dom/ElementDataCache.cpp

Issue 1854423002: ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mark svg/as-image/svg-nested.html crash on win Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012, 2013 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2012, 2013 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 26 matching lines...) Expand all
37 37
38 inline bool hasSameAttributes(const Vector<Attribute>& attributes, ShareableElem entData& elementData) 38 inline bool hasSameAttributes(const Vector<Attribute>& attributes, ShareableElem entData& elementData)
39 { 39 {
40 if (attributes.size() != elementData.attributes().size()) 40 if (attributes.size() != elementData.attributes().size())
41 return false; 41 return false;
42 return !memcmp(attributes.data(), elementData.m_attributeArray, attributes.s ize() * sizeof(Attribute)); 42 return !memcmp(attributes.data(), elementData.m_attributeArray, attributes.s ize() * sizeof(Attribute));
43 } 43 }
44 44
45 RawPtr<ShareableElementData> ElementDataCache::cachedShareableElementDataWithAtt ributes(const Vector<Attribute>& attributes) 45 RawPtr<ShareableElementData> ElementDataCache::cachedShareableElementDataWithAtt ributes(const Vector<Attribute>& attributes)
46 { 46 {
47 ASSERT(!attributes.isEmpty()); 47 DCHECK(!attributes.isEmpty());
48 48
49 ShareableElementDataCache::ValueType* it = m_shareableElementDataCache.add(a ttributeHash(attributes), nullptr).storedValue; 49 ShareableElementDataCache::ValueType* it = m_shareableElementDataCache.add(a ttributeHash(attributes), nullptr).storedValue;
50 50
51 // FIXME: This prevents sharing when there's a hash collision. 51 // FIXME: This prevents sharing when there's a hash collision.
52 if (it->value && !hasSameAttributes(attributes, *it->value)) 52 if (it->value && !hasSameAttributes(attributes, *it->value))
53 return ShareableElementData::createWithAttributes(attributes); 53 return ShareableElementData::createWithAttributes(attributes);
54 54
55 if (!it->value) 55 if (!it->value)
56 it->value = ShareableElementData::createWithAttributes(attributes); 56 it->value = ShareableElementData::createWithAttributes(attributes);
57 57
58 return it->value.get(); 58 return it->value.get();
59 } 59 }
60 60
61 ElementDataCache::ElementDataCache() 61 ElementDataCache::ElementDataCache()
62 { 62 {
63 } 63 }
64 64
65 DEFINE_TRACE(ElementDataCache) 65 DEFINE_TRACE(ElementDataCache)
66 { 66 {
67 visitor->trace(m_shareableElementDataCache); 67 visitor->trace(m_shareableElementDataCache);
68 } 68 }
69 69
70 } // namespace blink 70 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/dom/ElementData.cpp ('k') | third_party/WebKit/Source/core/dom/ElementRareData.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698