Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: third_party/WebKit/Source/core/dom/IntersectionObservation.cpp

Issue 1854423002: ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mark svg/as-image/svg-nested.html crash on win Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/IntersectionObservation.cpp
diff --git a/third_party/WebKit/Source/core/dom/IntersectionObservation.cpp b/third_party/WebKit/Source/core/dom/IntersectionObservation.cpp
index 454cbe00e5105a1334ec5dc6c61e861b52b31c38..a6c36d712a0bff05614d86ea4e8861d9fae9ea4f 100644
--- a/third_party/WebKit/Source/core/dom/IntersectionObservation.cpp
+++ b/third_party/WebKit/Source/core/dom/IntersectionObservation.cpp
@@ -44,9 +44,9 @@ void IntersectionObservation::initializeGeometry(IntersectionGeometry& geometry)
void IntersectionObservation::initializeTargetRect(LayoutRect& rect) const
{
- ASSERT(m_target);
+ DCHECK(m_target);
LayoutObject* targetLayoutObject = target()->layoutObject();
- ASSERT(targetLayoutObject && targetLayoutObject->isBoxModelObject());
+ DCHECK(targetLayoutObject && targetLayoutObject->isBoxModelObject());
rect = toLayoutBoxModelObject(targetLayoutObject)->visualOverflowRect();
}
@@ -66,7 +66,7 @@ void IntersectionObservation::clipToRoot(IntersectionGeometry& geometry) const
{
// Map and clip rect into root element coordinates.
// TODO(szager): the writing mode flipping needs a test.
- ASSERT(m_target);
+ DCHECK(m_target);
LayoutObject* rootLayoutObject = m_observer->rootLayoutObject();
LayoutObject* targetLayoutObject = target()->layoutObject();
@@ -154,7 +154,7 @@ bool IntersectionObservation::computeGeometry(IntersectionGeometry& geometry) co
if (!targetElement || !targetElement->inShadowIncludingDocument())
return false;
LayoutObject* targetLayoutObject = targetElement->layoutObject();
- ASSERT(m_observer);
+ DCHECK(m_observer);
LayoutObject* rootLayoutObject = m_observer->rootLayoutObject();
// TODO(szager): Support SVG
if (!targetLayoutObject)

Powered by Google App Engine
This is Rietveld 408576698