Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: third_party/WebKit/Source/core/dom/CharacterData.h

Issue 1854423002: ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mark svg/as-image/svg-nested.html crash on win Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009 Apple Inc. All rights reserv ed. 4 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009 Apple Inc. All rights reserv ed.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 50
51 StringImpl* dataImpl() { return m_data.impl(); } 51 StringImpl* dataImpl() { return m_data.impl(); }
52 52
53 void parserAppendData(const String&); 53 void parserAppendData(const String&);
54 54
55 protected: 55 protected:
56 CharacterData(TreeScope& treeScope, const String& text, ConstructionType typ e) 56 CharacterData(TreeScope& treeScope, const String& text, ConstructionType typ e)
57 : Node(&treeScope, type) 57 : Node(&treeScope, type)
58 , m_data(!text.isNull() ? text : emptyString()) 58 , m_data(!text.isNull() ? text : emptyString())
59 { 59 {
60 ASSERT(type == CreateOther || type == CreateText || type == CreateEditin gText); 60 DCHECK(type == CreateOther || type == CreateText || type == CreateEditin gText);
61 } 61 }
62 62
63 void setDataWithoutUpdate(const String& data) 63 void setDataWithoutUpdate(const String& data)
64 { 64 {
65 ASSERT(!data.isNull()); 65 DCHECK(!data.isNull());
66 m_data = data; 66 m_data = data;
67 } 67 }
68 enum UpdateSource { 68 enum UpdateSource {
69 UpdateFromParser, 69 UpdateFromParser,
70 UpdateFromNonParser, 70 UpdateFromNonParser,
71 }; 71 };
72 void didModifyData(const String& oldValue, UpdateSource); 72 void didModifyData(const String& oldValue, UpdateSource);
73 73
74 String m_data; 74 String m_data;
75 75
76 private: 76 private:
77 String nodeValue() const final; 77 String nodeValue() const final;
78 void setNodeValue(const String&) final; 78 void setNodeValue(const String&) final;
79 bool isCharacterDataNode() const final { return true; } 79 bool isCharacterDataNode() const final { return true; }
80 int maxCharacterOffset() const final; 80 int maxCharacterOffset() const final;
81 void setDataAndUpdate(const String&, unsigned offsetOfReplacedData, unsigned oldLength, unsigned newLength, UpdateSource = UpdateFromNonParser, RecalcStyleB ehavior = DoNotRecalcStyle); 81 void setDataAndUpdate(const String&, unsigned offsetOfReplacedData, unsigned oldLength, unsigned newLength, UpdateSource = UpdateFromNonParser, RecalcStyleB ehavior = DoNotRecalcStyle);
82 82
83 bool isContainerNode() const = delete; // This will catch anyone doing an un necessary check. 83 bool isContainerNode() const = delete; // This will catch anyone doing an un necessary check.
84 bool isElementNode() const = delete; // This will catch anyone doing an unne cessary check. 84 bool isElementNode() const = delete; // This will catch anyone doing an unne cessary check.
85 }; 85 };
86 86
87 DEFINE_NODE_TYPE_CASTS(CharacterData, isCharacterDataNode()); 87 DEFINE_NODE_TYPE_CASTS(CharacterData, isCharacterDataNode());
88 88
89 } // namespace blink 89 } // namespace blink
90 90
91 #endif // CharacterData_h 91 #endif // CharacterData_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/dom/CSSSelectorWatch.cpp ('k') | third_party/WebKit/Source/core/dom/CharacterData.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698