third_party/WebKit/Source/core/dom/ChildNodeList.cpp - Issue 1854423002: ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ChildNodeList.cpp

Issue 1854423002: ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mark svg/as-image/svg-nested.html crash on win Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/ChildListMutationScope.cpp ('k') | third_party/WebKit/Source/core/dom/CompositorProxiedPropertySet.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/ChildNodeList.cpp

diff --git a/third_party/WebKit/Source/core/dom/ChildNodeList.cpp b/third_party/WebKit/Source/core/dom/ChildNodeList.cpp

index 2477ce13bfad8e9bac8cff254184ee67ccdb4c15..10de9adca482e0b6e8446a993cfcc0ec8b4c4208 100644

--- a/third_party/WebKit/Source/core/dom/ChildNodeList.cpp

+++ b/third_party/WebKit/Source/core/dom/ChildNodeList.cpp

@@ -47,7 +47,7 @@ ChildNodeList::~ChildNodeList()

Node* ChildNodeList::traverseForwardToOffset(unsigned offset, Node& currentNode, unsigned& currentOffset) const

{

- ASSERT(currentOffset < offset);

+ DCHECK_LT(currentOffset, offset);

for (Node* next = currentNode.nextSibling(); next; next = next->nextSibling()) {

if (++currentOffset == offset)

return next;

@@ -57,7 +57,7 @@ Node* ChildNodeList::traverseForwardToOffset(unsigned offset, Node& currentNode,

Node* ChildNodeList::traverseBackwardToOffset(unsigned offset, Node& currentNode, unsigned& currentOffset) const

{

- ASSERT(currentOffset > offset);

+ DCHECK_GT(currentOffset, offset);

for (Node* previous = currentNode.previousSibling(); previous; previous = previous->previousSibling()) {

if (--currentOffset == offset)

return previous;