Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: third_party/WebKit/Source/core/dom/LayoutTreeBuilderTraversal.cpp

Issue 1854423002: ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mark svg/as-image/svg-nested.html crash on win Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/LayoutTreeBuilderTraversal.cpp
diff --git a/third_party/WebKit/Source/core/dom/LayoutTreeBuilderTraversal.cpp b/third_party/WebKit/Source/core/dom/LayoutTreeBuilderTraversal.cpp
index 6da91988c6185700fb05ad955870ff0e4644a417..8d022d28842828184ec995187062fedabecedef9 100644
--- a/third_party/WebKit/Source/core/dom/LayoutTreeBuilderTraversal.cpp
+++ b/third_party/WebKit/Source/core/dom/LayoutTreeBuilderTraversal.cpp
@@ -54,7 +54,7 @@ void ParentDetails::didTraverseInsertionPoint(const InsertionPoint* insertionPoi
ContainerNode* parent(const Node& node, ParentDetails* details)
{
// TODO(hayato): Uncomment this once we can be sure LayoutTreeBuilderTraversal::parent() is used only for a node in a document.
- // ASSERT(node.inShadowIncludingDocument());
+ // DCHECK(node.inShadowIncludingDocument());
return FlatTreeTraversal::parent(node, details);
}
@@ -186,8 +186,8 @@ static Node* pseudoAwareFirstChild(const Node& node)
static Node* nextAncestorSibling(const Node& node, const Node* stayWithin)
{
- ASSERT(!pseudoAwareNextSibling(node));
- ASSERT(node != stayWithin);
+ DCHECK(!pseudoAwareNextSibling(node));
+ DCHECK_NE(node, stayWithin);
for (Node* parentNode = parent(node); parentNode; parentNode = parent(*parentNode)) {
if (parentNode == stayWithin)
return 0;
@@ -239,7 +239,7 @@ LayoutObject* nextInTopLayer(const Element& element)
return 0;
const HeapVector<Member<Element>>& topLayerElements = element.document().topLayerElements();
size_t position = topLayerElements.find(&element);
- ASSERT(position != kNotFound);
+ DCHECK_NE(position, kNotFound);
for (size_t i = position + 1; i < topLayerElements.size(); ++i) {
if (LayoutObject* layoutObject = topLayerElements[i]->layoutObject())
return layoutObject;
« no previous file with comments | « third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp ('k') | third_party/WebKit/Source/core/dom/LiveNodeListBase.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698