Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: third_party/WebKit/Source/core/dom/DOMException.cpp

Issue 1854423002: ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mark svg/as-image/svg-nested.html crash on win Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/DOMException.cpp
diff --git a/third_party/WebKit/Source/core/dom/DOMException.cpp b/third_party/WebKit/Source/core/dom/DOMException.cpp
index fe9e1b8a673afe04e937f7d64c2ea3a28c1a526b..6cfc6639ea9fa1edd7e28d329528b79c2e3d4693 100644
--- a/third_party/WebKit/Source/core/dom/DOMException.cpp
+++ b/third_party/WebKit/Source/core/dom/DOMException.cpp
@@ -109,7 +109,7 @@ static int getErrorCode(const String& name)
DOMException::DOMException(unsigned short code, const String& name, const String& sanitizedMessage, const String& unsanitizedMessage)
{
- ASSERT(name);
+ DCHECK(name);
m_code = code;
m_name = name;
m_sanitizedMessage = sanitizedMessage;
@@ -119,7 +119,7 @@ DOMException::DOMException(unsigned short code, const String& name, const String
DOMException* DOMException::create(ExceptionCode ec, const String& sanitizedMessage, const String& unsanitizedMessage)
{
const CoreException* entry = getErrorEntry(ec);
- ASSERT(entry);
+ DCHECK(entry);
return new DOMException(entry->code,
entry->name ? entry->name : "Error",
sanitizedMessage.isNull() ? String(entry->message) : sanitizedMessage,
@@ -144,7 +144,7 @@ String DOMException::toStringForConsole() const
String DOMException::getErrorName(ExceptionCode ec)
{
const CoreException* entry = getErrorEntry(ec);
- ASSERT(entry);
+ DCHECK(entry);
if (!entry)
return "UnknownError";
@@ -154,7 +154,7 @@ String DOMException::getErrorName(ExceptionCode ec)
String DOMException::getErrorMessage(ExceptionCode ec)
{
const CoreException* entry = getErrorEntry(ec);
- ASSERT(entry);
+ DCHECK(entry);
if (!entry)
return "Unknown error.";
« no previous file with comments | « third_party/WebKit/Source/core/dom/DOMDataView.cpp ('k') | third_party/WebKit/Source/core/dom/DOMImplementation.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698