third_party/WebKit/Source/core/dom/ContainerNode.h - Issue 1854423002: ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ContainerNode.h

Issue 1854423002: ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mark svg/as-image/svg-nested.html crash on win Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/CompositorProxy.cpp ('k') | third_party/WebKit/Source/core/dom/ContainerNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/ContainerNode.h

diff --git a/third_party/WebKit/Source/core/dom/ContainerNode.h b/third_party/WebKit/Source/core/dom/ContainerNode.h

index e4e7c4bbd7312278afdd2a37337158c1203b1df3..cd192c01ec24c85e3969c9794ce6c7c895426c3e 100644

--- a/third_party/WebKit/Source/core/dom/ContainerNode.h

+++ b/third_party/WebKit/Source/core/dom/ContainerNode.h

@@ -265,7 +265,7 @@ private:

Member<Node> m_lastChild;

};

-#if ENABLE(ASSERT)

+#if DCHECK_IS_ON()

bool childAttachedAllowedWhenAttachingChildren(ContainerNode*);

#endif

@@ -337,7 +337,7 @@ inline bool Node::isTreeScope() const

inline void getChildNodes(ContainerNode& node, NodeVector& nodes)

{

- ASSERT(!nodes.size());

+ DCHECK(!nodes.size());

for (Node* child = node.firstChild(); child; child = child->nextSibling())

nodes.append(child);

}

« no previous file with comments | « third_party/WebKit/Source/core/dom/CompositorProxy.cpp ('k') | third_party/WebKit/Source/core/dom/ContainerNode.cpp » ('j') | no next file with comments »