Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: third_party/WebKit/Source/core/dom/NodeTraversal.cpp

Issue 1854423002: ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mark svg/as-image/svg-nested.html crash on win Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/NodeTraversal.cpp
diff --git a/third_party/WebKit/Source/core/dom/NodeTraversal.cpp b/third_party/WebKit/Source/core/dom/NodeTraversal.cpp
index 12059a88b838270177cb9e9c2aee6a7a79717555..25c00e0f69aaeb2e5d37a2ea3b7b5bdc54b72963 100644
--- a/third_party/WebKit/Source/core/dom/NodeTraversal.cpp
+++ b/third_party/WebKit/Source/core/dom/NodeTraversal.cpp
@@ -75,7 +75,7 @@ Node* NodeTraversal::nextIncludingPseudoSkippingChildren(const Node& current, co
Node* NodeTraversal::nextAncestorSibling(const Node& current)
{
- ASSERT(!current.nextSibling());
+ DCHECK(!current.nextSibling());
for (Node* parent = current.parentNode(); parent; parent = parent->parentNode()) {
if (parent->nextSibling())
return parent->nextSibling();
@@ -85,8 +85,8 @@ Node* NodeTraversal::nextAncestorSibling(const Node& current)
Node* NodeTraversal::nextAncestorSibling(const Node& current, const Node* stayWithin)
{
- ASSERT(!current.nextSibling());
- ASSERT(current != stayWithin);
+ DCHECK(!current.nextSibling());
+ DCHECK_NE(current, stayWithin);
for (Node* parent = current.parentNode(); parent; parent = parent->parentNode()) {
if (parent == stayWithin)
return 0;
@@ -152,7 +152,7 @@ Node* NodeTraversal::nextPostOrder(const Node& current, const Node* stayWithin)
static Node* previousAncestorSiblingPostOrder(const Node& current, const Node* stayWithin)
{
- ASSERT(!current.previousSibling());
+ DCHECK(!current.previousSibling());
for (Node* parent = current.parentNode(); parent; parent = parent->parentNode()) {
if (parent == stayWithin)
return 0;
« no previous file with comments | « third_party/WebKit/Source/core/dom/NodeRareData.h ('k') | third_party/WebKit/Source/core/dom/NodeWithIndex.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698