Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: third_party/WebKit/Source/core/dom/TreeScope.h

Issue 1854423002: ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mark svg/as-image/svg-nested.html crash on win Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/dom/Text.cpp ('k') | third_party/WebKit/Source/core/dom/TreeScope.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/TreeScope.h
diff --git a/third_party/WebKit/Source/core/dom/TreeScope.h b/third_party/WebKit/Source/core/dom/TreeScope.h
index 9cf5b49b83aeaaa2308bd363c751b426bb4c3e09..93fcd0a5ac660828ec5ed9b67e2e8f03ff579b6b 100644
--- a/third_party/WebKit/Source/core/dom/TreeScope.h
+++ b/third_party/WebKit/Source/core/dom/TreeScope.h
@@ -67,7 +67,7 @@ public:
Document& document() const
{
- ASSERT(m_document);
+ DCHECK(m_document);
return *m_document;
}
@@ -114,14 +114,14 @@ public:
// pointer without introducing reference cycles.
void guardRef()
{
- ASSERT(!deletionHasBegun());
+ DCHECK(!deletionHasBegun());
++m_guardRefCount;
}
void guardDeref()
{
- ASSERT(m_guardRefCount > 0);
- ASSERT(!deletionHasBegun());
+ DCHECK_GT(m_guardRefCount, 0);
+ DCHECK(!deletionHasBegun());
--m_guardRefCount;
if (!m_guardRefCount && !refCount() && !rootNodeHasTreeSharedParent()) {
beginDeletion();
@@ -204,7 +204,7 @@ private:
inline bool TreeScope::hasElementWithId(const AtomicString& id) const
{
- ASSERT(!id.isNull());
+ DCHECK(!id.isNull());
return m_elementsById && m_elementsById->contains(id);
}
« no previous file with comments | « third_party/WebKit/Source/core/dom/Text.cpp ('k') | third_party/WebKit/Source/core/dom/TreeScope.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698