third_party/WebKit/Source/core/dom/IntersectionObserver.cpp - Issue 1854423002: ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/IntersectionObserver.cpp

Issue 1854423002: ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mark svg/as-image/svg-nested.html crash on win Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/IntersectionObservation.cpp ('k') | third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/IntersectionObserver.cpp

diff --git a/third_party/WebKit/Source/core/dom/IntersectionObserver.cpp b/third_party/WebKit/Source/core/dom/IntersectionObserver.cpp

index 14f97d86709cf26e969c0c82f9bfe054091a36da..cb1f78ce9f058e1632701738d969c4b4da1ae0bf 100644

--- a/third_party/WebKit/Source/core/dom/IntersectionObserver.cpp

+++ b/third_party/WebKit/Source/core/dom/IntersectionObserver.cpp

@@ -86,7 +86,7 @@ IntersectionObserver* IntersectionObserver::create(const IntersectionObserverIni

if (!root) {

// TODO(szager): Use Document instead of document element for implicit root. (crbug.com/570538)

ExecutionContext* context = callback.getExecutionContext();

- ASSERT(context->isDocument());

+ DCHECK(context->isDocument());

Frame* mainFrame = toDocument(context)->frame()->tree().top();

if (mainFrame && mainFrame->isLocalFrame())

root = toLocalFrame(mainFrame)->document();

@@ -268,7 +268,7 @@ static LayoutUnit computeMargin(const Length& length, LayoutUnit referenceLength

{

if (length.type() == Percent)

return LayoutUnit(static_cast<int>(referenceLength.toFloat() * length.percent() / 100.0));

- ASSERT(length.type() == Fixed);

+ DCHECK_EQ(length.type(), Fixed);

return LayoutUnit(length.intValue());

}