third_party/WebKit/Source/core/dom/shadow/ElementShadow.h - Issue 1854423002: ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/shadow/ElementShadow.h

Issue 1854423002: ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mark svg/as-image/svg-nested.html crash on win Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/shadow/DistributedNodes.cpp ('k') | third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/shadow/ElementShadow.h

diff --git a/third_party/WebKit/Source/core/dom/shadow/ElementShadow.h b/third_party/WebKit/Source/core/dom/shadow/ElementShadow.h

index 9454f36ef14319eeaf3f8db31f06a6d9f32fd038..7dce62a0d336bbb96e80fcbb88f67509bbe8ba28 100644

--- a/third_party/WebKit/Source/core/dom/shadow/ElementShadow.h

+++ b/third_party/WebKit/Source/core/dom/shadow/ElementShadow.h

@@ -46,7 +46,7 @@ public:

~ElementShadow();

Element* host() const;

- ShadowRoot& youngestShadowRoot() const { ASSERT(m_shadowRoots.head()); return *m_shadowRoots.head(); }

+ ShadowRoot& youngestShadowRoot() const { DCHECK(m_shadowRoots.head()); return *m_shadowRoots.head(); }

ShadowRoot* oldestShadowRoot() const { return m_shadowRoots.tail(); }

ElementShadow* containingShadow() const;

@@ -59,7 +59,7 @@ public:

HTMLSlotElement* assignedSlotFor(const Node& node) const

{

- ASSERT(m_slotAssignment);

+ DCHECK(m_slotAssignment);

return m_slotAssignment->assignedSlotFor(node);

}

@@ -127,7 +127,7 @@ private:

inline Element* ElementShadow::host() const

{

- ASSERT(!m_shadowRoots.isEmpty());

+ DCHECK(!m_shadowRoots.isEmpty());

return youngestShadowRoot().host();

}