Create GrGLSLVaryingHandler class for program building

Create GrGLSLVaryingHandler class for program building

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/0eafe79f42e3c675f3c504aed4a41abf511df2b7

[egdaniel, 2015-11-20 16:10:18]

egdaniel@google.com changed reviewers:
+ bsalomon@google.com, joshualitt@chromium.org

[egdaniel, 2015-11-20 16:10:18]

This cl actually has some architecture type changes unlike many of my recent
name change CLs so you may want to take a closer look.

[joshualitt, 2015-11-20 17:51:58]

joshualitt@google.com changed reviewers:
+ joshualitt@google.com

[joshualitt, 2015-11-20 17:51:59]

looks pretty reasonable, just some small things

https://codereview.chromium.org/1462123003/diff/20001/src/gpu/gl/GrGLVaryingH...
File src/gpu/gl/GrGLVaryingHandler.h (right):

https://codereview.chromium.org/1462123003/diff/20001/src/gpu/gl/GrGLVaryingH...
src/gpu/gl/GrGLVaryingHandler.h:15: class GrGLVaryingHandler : public
GrGLSLVaryingHandler {
This is really specific to NVPR and not GL

https://codereview.chromium.org/1462123003/diff/20001/src/gpu/glsl/GrGLSLVary...
File src/gpu/glsl/GrGLSLVarying.cpp (right):

https://codereview.chromium.org/1462123003/diff/20001/src/gpu/glsl/GrGLSLVary...
src/gpu/glsl/GrGLSLVarying.cpp:111: out->append(";\n");
remove \n

https://codereview.chromium.org/1462123003/diff/20001/src/gpu/glsl/GrGLSLVary...
File src/gpu/glsl/GrGLSLVarying.h (right):

https://codereview.chromium.org/1462123003/diff/20001/src/gpu/glsl/GrGLSLVary...
src/gpu/glsl/GrGLSLVarying.h:73: explicit
GrGLSLVaryingHandler(GrGLSLProgramBuilder* program)
not that it matters, but why is this explicit?

[bsalomon, 2015-11-20 18:20:36]

lgtm if we comment on why separable varyings exist.

https://codereview.chromium.org/1462123003/diff/20001/src/gpu/glsl/GrGLSLVary...
File src/gpu/glsl/GrGLSLVarying.h (right):

https://codereview.chromium.org/1462123003/diff/20001/src/gpu/glsl/GrGLSLVary...
src/gpu/glsl/GrGLSLVarying.h:73: explicit
GrGLSLVaryingHandler(GrGLSLProgramBuilder* program)
On 2015/11/20 17:51:58, joshualitt wrote:
> not that it matters, but why is this explicit?

We strive to make all single arg constructors explicit unless we really really
want the compiler to silently insert conversions.

[egdaniel, 2015-11-20 19:50:59]

The CQ bit was checked by egdaniel@google.com

[egdaniel, 2015-11-20 19:50:59]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1462123003/#ps40001
(title: "separable varying changes")

[commit-bot: I haz the power, 2015-11-20 19:51:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1462123003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1462123003/40001

[commit-bot: I haz the power, 2015-11-20 19:52:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-20 19:52:20]

Try jobs failed on following builders:
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[egdaniel, 2015-11-20 20:00:47]

The CQ bit was checked by egdaniel@google.com

[egdaniel, 2015-11-20 20:00:47]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1462123003/#ps60001
(title: "fix release builder")

[commit-bot: I haz the power, 2015-11-20 20:00:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1462123003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1462123003/60001

[commit-bot: I haz the power, 2015-11-20 22:01:25]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/0eafe79f42e3c675f3c504aed4a41abf511df2b7