Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1233363002: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references (Closed)

Created:
5 years, 5 months ago by sashab
Modified:
5 years, 4 months ago
Reviewers:
CC:
blink-reviews, shans, eae+blinkwatch, fs, apavlov+blink_chromium.org, kouhei+svg_chromium.org, rwlbuis, krit, blink-reviews-css, szager+layoutwatch_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, jchaffraix+rendering, gyuyoung2, pdr+svgwatchlist_chromium.org, Eric Willigers, kenneth.christiansen, rjwright, blink-reviews-style_chromium.org, zoltan1, sof, darktears, blink-reviews-rendering, blink-reviews-animation_chromium.org, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, f(malita), Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_4_attempt_2
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

CSSValue Immediates: Replace CSSValue usage with const references Replaced all instances of CSSValue and NullableCSSValue with const CSSValue& and const NullableCSSValue&, respectively, where possible. This is an attempt to reduce ref-churn instroduced by CSSValue. Depends on crrev.com/1234763007. This is part of a larger refactor of CSSValue to introduce immediates, discussed on the bug. BUG=486252 COMMIT=false

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+684 lines, -633 lines) Patch
M Source/build/scripts/templates/StyleBuilder.cpp.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl View 5 chunks +13 lines, -12 lines 0 comments Download
M Source/build/scripts/templates/StyleBuilderFunctions.h.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/CSSValueInterpolationType.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/animation/ColorStyleInterpolation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/ConstantStyleInterpolation.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/DeferredLegacyStyleInterpolation.h View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/animation/DeferredLegacyStyleInterpolation.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/animation/DoubleStyleInterpolation.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/animation/ImageStyleInterpolation.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/LengthBoxStyleInterpolation.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/LengthBoxStyleInterpolation.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M Source/core/animation/LengthPairStyleInterpolation.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/animation/LengthPairStyleInterpolationTest.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/animation/LengthStyleInterpolation.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/animation/LengthStyleInterpolation.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/animation/SVGStrokeDasharrayStyleInterpolation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/SVGStrokeDasharrayStyleInterpolationTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/ShadowStyleInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/ShadowStyleInterpolation.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/animation/StringKeyframe.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/animation/StringKeyframe.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/animation/VisibilityStyleInterpolation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/animatable/AnimatableImage.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/animation/animatable/AnimatableImage.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/animation/animatable/AnimatableUnknown.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/BasicShapeFunctions.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/css/CSSBasicShapes.h View 6 chunks +39 lines, -39 lines 0 comments Download
M Source/core/css/CSSBasicShapes.cpp View 3 chunks +8 lines, -9 lines 0 comments Download
M Source/core/css/CSSBorderImage.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSBorderImage.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSBorderImageSliceValue.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSBorderImageSliceValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSCalculationValue.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSCrossfadeValue.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSCrossfadeValue.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSCursorImageValue.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSCursorImageValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSGradientValue.h View 3 chunks +9 lines, -9 lines 0 comments Download
M Source/core/css/CSSGradientValue.cpp View 7 chunks +16 lines, -15 lines 0 comments Download
M Source/core/css/CSSPrimitiveValue.h View 1 2 2 chunks +21 lines, -3 lines 0 comments Download
M Source/core/css/CSSProperty.h View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/CSSProperty.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSReflectValue.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/css/CSSShadowValue.h View 2 chunks +12 lines, -12 lines 0 comments Download
M Source/core/css/CSSShadowValue.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/css/CSSValue.h View 1 2 9 chunks +62 lines, -28 lines 0 comments Download
M Source/core/css/CSSValueList.h View 1 1 chunk +5 lines, -7 lines 0 comments Download
M Source/core/css/CSSValueList.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSValueTest.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/css/Counter.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/css/FontFace.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/FontFace.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/Pair.h View 2 chunks +9 lines, -9 lines 0 comments Download
M Source/core/css/Rect.h View 1 chunk +9 lines, -9 lines 0 comments Download
M Source/core/css/RuleFeature.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/StylePropertySerializer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/StylePropertySerializer.cpp View 14 chunks +19 lines, -19 lines 0 comments Download
M Source/core/css/StylePropertySet.h View 4 chunks +4 lines, -6 lines 0 comments Download
M Source/core/css/StylePropertySet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/parser/CSSParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/parser/CSSPropertyParser.h View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 19 chunks +26 lines, -26 lines 0 comments Download
M Source/core/css/resolver/CSSToStyleMap.h View 1 chunk +21 lines, -21 lines 0 comments Download
M Source/core/css/resolver/CSSToStyleMap.cpp View 24 chunks +45 lines, -45 lines 0 comments Download
M Source/core/css/resolver/FilterOperationResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/StyleBuilder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderConverter.h View 3 chunks +56 lines, -56 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderConverter.cpp View 42 chunks +94 lines, -94 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 30 chunks +48 lines, -48 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/TransformBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/TransformBuilder.cpp View 7 chunks +9 lines, -9 lines 0 comments Download
M Source/core/css/resolver/ViewportStyleResolver.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/TextLinkColors.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/TextLinkColors.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/ApplyStyleCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/EditingStyle.cpp View 6 chunks +9 lines, -9 lines 0 comments Download
M Source/core/layout/svg/ReferenceFilterBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1234763007 Patch 60001

Messages

Total messages: 1 (1 generated)
sashab
5 years, 4 months ago (2015-07-29 05:13:59 UTC) #1 
Patchset #3 (id:40001) has been deleted

Powered by Google App Engine
This is Rietveld 408576698