Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Side by Side Diff: Source/core/css/CSSShadowValue.cpp

Issue 1233363002: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_4_attempt_2
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/css/CSSShadowValue.h ('k') | Source/core/css/CSSValue.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /** 1 /**
2 * (C) 1999-2003 Lars Knoll (knoll@kde.org) 2 * (C) 1999-2003 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2009 Apple Computer, Inc. 3 * Copyright (C) 2004, 2005, 2006, 2009 Apple Computer, Inc.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
11 * but WITHOUT ANY WARRANTY; without even the implied warranty of 11 * but WITHOUT ANY WARRANTY; without even the implied warranty of
12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
13 * Library General Public License for more details. 13 * Library General Public License for more details.
14 * 14 *
15 * You should have received a copy of the GNU Library General Public License 15 * You should have received a copy of the GNU Library General Public License
16 * along with this library; see the file COPYING.LIB. If not, write to 16 * along with this library; see the file COPYING.LIB. If not, write to
17 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 17 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
18 * Boston, MA 02110-1301, USA. 18 * Boston, MA 02110-1301, USA.
19 */ 19 */
20 #include "config.h" 20 #include "config.h"
21 #include "core/css/CSSShadowValue.h" 21 #include "core/css/CSSShadowValue.h"
22 22
23 #include "core/css/CSSPrimitiveValue.h" 23 #include "core/css/CSSPrimitiveValue.h"
24 #include "wtf/text/StringBuilder.h" 24 #include "wtf/text/StringBuilder.h"
25 #include "wtf/text/WTFString.h" 25 #include "wtf/text/WTFString.h"
26 26
27 namespace blink { 27 namespace blink {
28 28
29 // Used for text-shadow and box-shadow 29 // Used for text-shadow and box-shadow
30 CSSShadowValue::CSSShadowValue(NullableCSSValue x, 30 CSSShadowValue::CSSShadowValue(const NullableCSSValue& x,
31 NullableCSSValue y, 31 const NullableCSSValue& y,
32 NullableCSSValue blur, 32 const NullableCSSValue& blur,
33 NullableCSSValue spread, 33 const NullableCSSValue& spread,
34 NullableCSSValue style, 34 const NullableCSSValue& style,
35 NullableCSSValue color) 35 const NullableCSSValue& color)
36 : CSSValueObject(ShadowClass) 36 : CSSValueObject(ShadowClass)
37 , x(x) 37 , x(x)
38 , y(y) 38 , y(y)
39 , blur(blur) 39 , blur(blur)
40 , spread(spread) 40 , spread(spread)
41 , style(style) 41 , style(style)
42 , color(color) 42 , color(color)
43 { 43 {
44 } 44 }
45 45
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 visitor->trace(x); 93 visitor->trace(x);
94 visitor->trace(y); 94 visitor->trace(y);
95 visitor->trace(blur); 95 visitor->trace(blur);
96 visitor->trace(spread); 96 visitor->trace(spread);
97 visitor->trace(style); 97 visitor->trace(style);
98 visitor->trace(color); 98 visitor->trace(color);
99 CSSValueObject::traceAfterDispatch(visitor); 99 CSSValueObject::traceAfterDispatch(visitor);
100 } 100 }
101 101
102 } 102 }
OLDNEW
« no previous file with comments | « Source/core/css/CSSShadowValue.h ('k') | Source/core/css/CSSValue.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698