Source/core/css/resolver/ViewportStyleResolver.cpp - Issue 1233363002: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/ViewportStyleResolver.cpp

Issue 1233363002: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_4_attempt_2

Patch Set: Rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/resolver/ViewportStyleResolver.cpp

diff --git a/Source/core/css/resolver/ViewportStyleResolver.cpp b/Source/core/css/resolver/ViewportStyleResolver.cpp

index 28035aa9a8f429ae7b90ba7a366200905b288637..733bab88aacdbff395709d45b850bef174e29667 100644

--- a/Source/core/css/resolver/ViewportStyleResolver.cpp

+++ b/Source/core/css/resolver/ViewportStyleResolver.cpp

@@ -141,7 +141,7 @@ float ViewportStyleResolver::viewportArgumentValue(CSSPropertyID id) const

if (!value || !value->isPrimitiveValue())

return defaultValue;

- CSSPrimitiveValue primitiveValue = toCSSPrimitiveValue(*value);

+ const CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(*value);

if (primitiveValue.isNumber() || primitiveValue.isPx())

return primitiveValue.getFloatValue();

@@ -191,7 +191,7 @@ Length ViewportStyleResolver::viewportLengthValue(CSSPropertyID id) const

if (!value || !value->isPrimitiveValue())

return Length(); // auto

- CSSPrimitiveValue primitiveValue = toCSSPrimitiveValue(*value);

+ const CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(*value);

if (primitiveValue.getValueID() == CSSValueInternalExtendToZoom)

return Length(ExtendToZoom);

« no previous file with comments | « Source/core/css/resolver/TransformBuilder.cpp ('k') | Source/core/dom/TextLinkColors.h » ('j') | no next file with comments »