Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Unified Diff: Source/core/css/CSSShadowValue.h

Issue 1233363002: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_4_attempt_2
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/CSSReflectValue.h ('k') | Source/core/css/CSSShadowValue.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/CSSShadowValue.h
diff --git a/Source/core/css/CSSShadowValue.h b/Source/core/css/CSSShadowValue.h
index 7e92a680aab3a65067cae327186d5828afcd6814..fdec5a1799c8c4b8d0fe2f1d8147c365b20333e7 100644
--- a/Source/core/css/CSSShadowValue.h
+++ b/Source/core/css/CSSShadowValue.h
@@ -33,12 +33,12 @@ class CSSPrimitiveValue;
// Used for text-shadow and box-shadow
class CORE_EXPORT CSSShadowValue : public CSSValueObject {
public:
- static PassRefPtrWillBeRawPtr<CSSShadowValue> create(NullableCSSValue x,
- NullableCSSValue y,
- NullableCSSValue blur,
- NullableCSSValue spread,
- NullableCSSValue style,
- NullableCSSValue color)
+ static PassRefPtrWillBeRawPtr<CSSShadowValue> create(const NullableCSSValue& x,
+ const NullableCSSValue& y,
+ const NullableCSSValue& blur,
+ const NullableCSSValue& spread,
+ const NullableCSSValue& style,
+ const NullableCSSValue& color)
{
return adoptRefWillBeNoop(new CSSShadowValue(x, y, blur, spread, style, color));
}
@@ -57,12 +57,12 @@ public:
DECLARE_TRACE_AFTER_DISPATCH();
private:
- CSSShadowValue(NullableCSSValue x,
- NullableCSSValue y,
- NullableCSSValue blur,
- NullableCSSValue spread,
- NullableCSSValue style,
- NullableCSSValue color);
+ CSSShadowValue(const NullableCSSValue& x,
+ const NullableCSSValue& y,
+ const NullableCSSValue& blur,
+ const NullableCSSValue& spread,
+ const NullableCSSValue& style,
+ const NullableCSSValue& color);
};
DEFINE_CSS_VALUE_TYPE_CASTS(CSSShadowValue, isShadowValue());
« no previous file with comments | « Source/core/css/CSSReflectValue.h ('k') | Source/core/css/CSSShadowValue.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698