Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Unified Diff: Source/core/css/Counter.h

Issue 1233363002: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_4_attempt_2
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/CSSValueTest.cpp ('k') | Source/core/css/FontFace.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/Counter.h
diff --git a/Source/core/css/Counter.h b/Source/core/css/Counter.h
index cb253377a62c516c6f48b798dd16eb690fbea963..8b40a9de61af4d7cbe6480567b23c1514e2e407e 100644
--- a/Source/core/css/Counter.h
+++ b/Source/core/css/Counter.h
@@ -28,7 +28,7 @@ namespace blink {
class Counter : public RefCountedWillBeGarbageCollectedFinalized<Counter> {
public:
- static PassRefPtrWillBeRawPtr<Counter> create(CSSPrimitiveValue identifier, CSSPrimitiveValue listStyle, CSSPrimitiveValue separator)
+ static PassRefPtrWillBeRawPtr<Counter> create(const CSSPrimitiveValue& identifier, const CSSPrimitiveValue& listStyle, const CSSPrimitiveValue& separator)
{
return adoptRefWillBeNoop(new Counter(identifier, listStyle, separator));
}
@@ -39,9 +39,9 @@ public:
CSSValueID listStyleIdent() const { return toCSSPrimitiveValue(m_listStyle).getValueID(); }
- void setIdentifier(CSSPrimitiveValue identifier) { m_identifier = identifier; }
- void setListStyle(CSSPrimitiveValue listStyle) { m_listStyle = listStyle; }
- void setSeparator(CSSPrimitiveValue separator) { m_separator = separator; }
+ void setIdentifier(const CSSPrimitiveValue& identifier) { m_identifier = identifier; }
+ void setListStyle(const CSSPrimitiveValue& listStyle) { m_listStyle = listStyle; }
+ void setSeparator(const CSSPrimitiveValue& separator) { m_separator = separator; }
bool equals(const Counter& other) const
{
@@ -53,7 +53,7 @@ public:
DECLARE_TRACE();
private:
- Counter(CSSPrimitiveValue identifier, CSSPrimitiveValue listStyle, CSSPrimitiveValue separator)
+ Counter(const CSSPrimitiveValue& identifier, const CSSPrimitiveValue& listStyle, const CSSPrimitiveValue& separator)
: m_identifier(identifier)
, m_listStyle(listStyle)
, m_separator(separator) { }
« no previous file with comments | « Source/core/css/CSSValueTest.cpp ('k') | Source/core/css/FontFace.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698