Source/core/css/FontFace.h - Issue 1233363002: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/FontFace.h

Issue 1233363002: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_4_attempt_2

Patch Set: Rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/FontFace.h

diff --git a/Source/core/css/FontFace.h b/Source/core/css/FontFace.h

index 38084ccc5eac2fc6e39b5a6e2f6df3f2d3888d93..f4664cbd9efaba68423b8351bacf076adaac6bfe 100644

--- a/Source/core/css/FontFace.h

+++ b/Source/core/css/FontFace.h

@@ -120,11 +120,11 @@ private:

explicit FontFace(ExecutionContext*);

FontFace(ExecutionContext*, const AtomicString& family, const FontFaceDescriptors&);

- void initCSSFontFace(Document*, CSSValue src);

+ void initCSSFontFace(Document*, const CSSValue& src);

void initCSSFontFace(const unsigned char* data, unsigned size);

void setPropertyFromString(const Document*, const String&, CSSPropertyID, ExceptionState* = 0);

bool setPropertyFromStyle(const StylePropertySet&, CSSPropertyID);

- bool setPropertyValue(NullableCSSValue, CSSPropertyID);

+ bool setPropertyValue(const NullableCSSValue&, CSSPropertyID);

bool setFamilyValue(CSSValueList*);

void loadInternal(ExecutionContext*);

ScriptPromise fontStatusPromise(ScriptState*);

« no previous file with comments | « Source/core/css/Counter.h ('k') | Source/core/css/FontFace.cpp » ('j') | no next file with comments »