Source/core/css/resolver/StyleBuilder.h - Issue 1233363002: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/StyleBuilder.h

Issue 1233363002: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_4_attempt_2

Patch Set: Rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/resolver/StyleBuilder.h

diff --git a/Source/core/css/resolver/StyleBuilder.h b/Source/core/css/resolver/StyleBuilder.h

index 28e64069abb7096f1f0865c9943ef9f6d020b294..eed82fee18bafa10ec52ccf57949b75e56e83f9f 100644

--- a/Source/core/css/resolver/StyleBuilder.h

+++ b/Source/core/css/resolver/StyleBuilder.h

@@ -43,10 +43,10 @@ class StyleResolverState;

class CORE_EXPORT StyleBuilder {

STATIC_ONLY(StyleBuilder);

public:

- static void applyProperty(CSSPropertyID, StyleResolverState&, CSSValue);

+ static void applyProperty(CSSPropertyID, StyleResolverState&, const CSSValue&);

private:

- static void applyProperty(CSSPropertyID, StyleResolverState&, CSSValue, bool isInitial, bool isInherit);

+ static void applyProperty(CSSPropertyID, StyleResolverState&, const CSSValue&, bool isInitial, bool isInherit);

};

}

« no previous file with comments | « Source/core/css/resolver/FilterOperationResolver.cpp ('k') | Source/core/css/resolver/StyleBuilderConverter.h » ('j') | no next file with comments »