Source/core/animation/ColorStyleInterpolation.cpp - Issue 1233363002: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/ColorStyleInterpolation.cpp

Issue 1233363002: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_4_attempt_2

Patch Set: Rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/animation/ColorStyleInterpolation.cpp

diff --git a/Source/core/animation/ColorStyleInterpolation.cpp b/Source/core/animation/ColorStyleInterpolation.cpp

index b97eb87148404fc04af20e54f6a2821a649ec56b..c3e6241f06ed262a51cfeab2230e3b7cc0aa7fab 100644

--- a/Source/core/animation/ColorStyleInterpolation.cpp

+++ b/Source/core/animation/ColorStyleInterpolation.cpp

@@ -25,7 +25,7 @@ bool ColorStyleInterpolation::canCreateFrom(const CSSValue& value)

PassOwnPtrWillBeRawPtr<InterpolableValue> ColorStyleInterpolation::colorToInterpolableValue(const CSSValue& value)

{

ASSERT(value.isPrimitiveValue());

- const CSSPrimitiveValue primitive = toCSSPrimitiveValue(value);

+ const CSSPrimitiveValue& primitive = toCSSPrimitiveValue(value);

RGBA32 color;

if (primitive.isValueID()) {

if (CSSPropertyParser::isSystemColor(primitive.getValueID())) {

« no previous file with comments | « Source/core/animation/CSSValueInterpolationType.h ('k') | Source/core/animation/ConstantStyleInterpolation.h » ('j') | no next file with comments »