Source/core/css/resolver/FilterOperationResolver.cpp - Issue 1233363002: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/FilterOperationResolver.cpp

Issue 1233363002: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_4_attempt_2

Patch Set: Rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/resolver/FilterOperationResolver.cpp

diff --git a/Source/core/css/resolver/FilterOperationResolver.cpp b/Source/core/css/resolver/FilterOperationResolver.cpp

index 055ae7befb5aa98a13c4e25f8cfee786e077784d..3ea60e5691354831a05082f1dd5cf3ac96b1f492 100644

--- a/Source/core/css/resolver/FilterOperationResolver.cpp

+++ b/Source/core/css/resolver/FilterOperationResolver.cpp

@@ -76,7 +76,7 @@ bool FilterOperationResolver::createFilterOperations(CSSValue inValue, const CSS

ASSERT(outOperations.isEmpty());

if (inValue.isPrimitiveValue()) {

- CSSPrimitiveValue primitiveValue = toCSSPrimitiveValue(inValue);

+ const CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(inValue);

if (primitiveValue.getValueID() == CSSValueNone)

return true;

}

« no previous file with comments | « Source/core/css/resolver/CSSToStyleMap.cpp ('k') | Source/core/css/resolver/StyleBuilder.h » ('j') | no next file with comments »