Source/core/css/RuleFeature.cpp - Issue 1233363002: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/RuleFeature.cpp

Issue 1233363002: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_4_attempt_2

Patch Set: Rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/RuleFeature.cpp

diff --git a/Source/core/css/RuleFeature.cpp b/Source/core/css/RuleFeature.cpp

index a53d9f3850c16d019ef7afbc94b60728caa95b7a..665b1c69233dec445200957f16ae02447eacd87d 100644

--- a/Source/core/css/RuleFeature.cpp

+++ b/Source/core/css/RuleFeature.cpp

@@ -313,7 +313,7 @@ void RuleFeatureSet::updateInvalidationSetsForContentAttribute(const RuleData& r

for (auto& item : toCSSValueList(contentValue)) {

if (!item.isPrimitiveValue())

continue;

- CSSPrimitiveValue primitiveItem = toCSSPrimitiveValue(item);

+ const CSSPrimitiveValue& primitiveItem = toCSSPrimitiveValue(item);

if (!primitiveItem.isAttr())

continue;

ensureAttributeInvalidationSet(AtomicString(primitiveItem.getStringValue()));

« no previous file with comments | « Source/core/css/Rect.h ('k') | Source/core/css/StylePropertySerializer.h » ('j') | no next file with comments »